Reset trace headers for bulk items when returning to pool#5317
Merged
michel-laterman merged 2 commits intoelastic:mainfrom Aug 26, 2025
Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
ycombinator
reviewed
Aug 22, 2025
changelog/fragments/1755810145-Reset-trace-headers-on-bulk-items-when-returning-to-pool.yaml
Show resolved
Hide resolved
ycombinator
approved these changes
Aug 26, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Reset trace headers * Add pr ref to changelog (cherry picked from commit 138a4e0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Reset trace headers * Add pr ref to changelog (cherry picked from commit 138a4e0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Reset trace headers * Add pr ref to changelog (cherry picked from commit 138a4e0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Reset trace headers * Add pr ref to changelog (cherry picked from commit 138a4e0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Reset trace headers * Add pr ref to changelog (cherry picked from commit 138a4e0)
michel-laterman
added a commit
that referenced
this pull request
Aug 26, 2025
michel-laterman
added a commit
that referenced
this pull request
Aug 26, 2025
michel-laterman
added a commit
that referenced
this pull request
Aug 26, 2025
michel-laterman
added a commit
that referenced
this pull request
Aug 26, 2025
michel-laterman
added a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the problem this PR solves?
Bulker items can have a previous item's trace links.
How does this PR solve the problem?
Clear the reference to the trace link in the block's reset method. This method is called before a block is put back in the sync.Pool.
Note that this fix would only apply to functions using the bulker without a transaction tied to their context.