[9.0](backport #4912) Convert Makefile to magefile.go#5395
Closed
mergify[bot] wants to merge 1 commit into9.0from
Closed
[9.0](backport #4912) Convert Makefile to magefile.go#5395mergify[bot] wants to merge 1 commit into9.0from
mergify[bot] wants to merge 1 commit into9.0from
Conversation
Reimplement Makefile targets in mage. Change buildkite pipeline to use mage. Change Dockerfile* to use mage. (cherry picked from commit db5f46b) # Conflicts: # .buildkite/pipeline.yml # .buildkite/scripts/common.sh # .buildkite/scripts/local_build.sh # .buildkite/scripts/test-release.sh # .buildkite/scripts/unit_test.sh # Dockerfile.fips # Makefile # NOTICE.txt # dev-tools/cloud/Makefile # dev-tools/cloud/terraform/main.tf # dev-tools/e2e/Dockerfile # dev-tools/e2e/build.sh # dev-tools/e2e/validatecerts.go # dev-tools/go.mod # dev-tools/go.sum # docs/fips.md # testing/e2e/fips_test.go
Contributor
Author
|
Cherry-pick of db5f46b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
8 tasks
Contributor
|
Replaced with #5423 |
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
The Makefile has reached a point where it is becoming difficult to understand and add new features/targets.
How does this PR solve the problem?
Reimplement Makefile targets in mage.
Change buildkite pipeline to use mage.
Change
Dockerfile*to use mage.Added bonuses:
NOTICE-FIPS.txtHow to test this PR locally
mage -lSee doc strings for targets with
mage -h TARGETi.e.: