Refactor the bulk checkin handler to use optional args#5493
Merged
michel-laterman merged 3 commits intoelastic:mainfrom Sep 11, 2025
Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Refactor the bulk checkin handler to use optional args so the list is easier to read and so that we can more easily add policy ID/revision idx identifiers as a follow up.
1d15f6f to
550203c
Compare
michel-laterman
commented
Sep 10, 2025
Contributor
Author
|
buildkite run perf-tests |
pchila
reviewed
Sep 11, 2025
pchila
approved these changes
Sep 11, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the problem this PR solves?
checkin.Bulk.CheckInfunction is hard to extend or understand at a glance.How does this PR solve the problem?
Refactor the bulk checkin handler to use optional args so the list is easier to read and so that we can more easily add policy ID/revision idx identifiers as a follow up.
How to test this PR locally
mage testDesign Checklist
I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues