Skip to content

Refactor the bulk checkin handler to use optional args#5493

Merged
michel-laterman merged 3 commits intoelastic:mainfrom
michel-laterman:enhancement/checkin-bulk-refactor
Sep 11, 2025
Merged

Refactor the bulk checkin handler to use optional args#5493
michel-laterman merged 3 commits intoelastic:mainfrom
michel-laterman:enhancement/checkin-bulk-refactor

Conversation

@michel-laterman
Copy link
Contributor

What is the problem this PR solves?

checkin.Bulk.CheckIn function is hard to extend or understand at a glance.

How does this PR solve the problem?

Refactor the bulk checkin handler to use optional args so the list is easier to read and so that we can more easily add policy ID/revision idx identifiers as a follow up.

How to test this PR locally

mage test

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@michel-laterman michel-laterman added enhancement New feature or request backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Sep 10, 2025
@prodsecmachine
Copy link

prodsecmachine commented Sep 10, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Refactor the bulk checkin handler to use optional args so the list is
easier to read and so that we can more easily add policy ID/revision idx
identifiers as a follow up.
@michel-laterman michel-laterman force-pushed the enhancement/checkin-bulk-refactor branch from 1d15f6f to 550203c Compare September 10, 2025 21:45
@michel-laterman
Copy link
Contributor Author

buildkite run perf-tests

@michel-laterman michel-laterman marked this pull request as ready for review September 11, 2025 00:04
@michel-laterman michel-laterman requested a review from a team as a code owner September 11, 2025 00:04
@michel-laterman michel-laterman enabled auto-merge (squash) September 11, 2025 18:38
@michel-laterman michel-laterman merged commit 0d00710 into elastic:main Sep 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

3 participants