Skip to content

[okta] Make event.original optional - #1009

Merged
marc-gr merged 1 commit into
elastic:masterfrom
marc-gr:okta-changes
May 27, 2021
Merged

[okta] Make event.original optional#1009
marc-gr merged 1 commit into
elastic:masterfrom
marc-gr:okta-changes

Conversation

@marc-gr

@marc-gr marc-gr commented May 19, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes event.original optional in the same way as the rest of packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

image

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr mentioned this pull request May 19, 2021
43 tasks
@elasticmachine

elasticmachine commented May 19, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-05-26T22:28:35.568+0000

  • Duration: 11 min 40 sec

  • Commit: 30d0d05

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a small comment, and if you could bump ECS version as well it would be great.

Comment thread packages/okta/data_stream/system/manifest.yml
@marc-gr
marc-gr merged commit e9b126c into elastic:master May 27, 2021
@marc-gr
marc-gr deleted the okta-changes branch May 27, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:okta Okta

3 participants