Skip to content

[fortinet_fortiproxy]: update documentation - #10098

Merged
pkoutsovasilis merged 5 commits into
mainfrom
fix/fortinet_fortiproxy_documentation
Jun 7, 2024
Merged

[fortinet_fortiproxy]: update documentation#10098
pkoutsovasilis merged 5 commits into
mainfrom
fix/fortinet_fortiproxy_documentation

Conversation

@pkoutsovasilis

@pkoutsovasilis pkoutsovasilis commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

update Documentation to remove sensitive information

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test

Related issues

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis changed the title fix: update documentation Jun 7, 2024
@pkoutsovasilis pkoutsovasilis added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Jun 7, 2024
@pkoutsovasilis
pkoutsovasilis marked this pull request as ready for review June 7, 2024 11:56
@pkoutsovasilis
pkoutsovasilis requested a review from a team as a code owner June 7, 2024 11:56
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@pkoutsovasilis pkoutsovasilis self-assigned this Jun 7, 2024

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind, let's remove these for now, I'll follow up with generic versions of these logs. (recreated from scratch)

@pkoutsovasilis

Copy link
Copy Markdown
Contributor Author

I changed my mind, let's remove these for now, I'll follow up with generic versions of these logs. (recreated from scratch)

Ok removed the respective entries and replaced them with samples from others in docs/README.md and sample_event.json

@pkoutsovasilis

Copy link
Copy Markdown
Contributor Author

@taylor-swanson your commit LGTM! unfortunately for obvious reasons I can't approve it 😆

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @pkoutsovasilis

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis
pkoutsovasilis merged commit 736b1f5 into main Jun 7, 2024
@elasticmachine

Copy link
Copy Markdown

Package fortinet_fortiproxy - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortiproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:fortinet_fortiproxy Fortinet FortiProxy Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants