Skip to content

[sentinel_one] Add agent.id to all agent related data - #10102

Merged
chrisberkhout merged 3 commits into
elastic:mainfrom
chrisberkhout:s1-agent-id
Jun 10, 2024
Merged

[sentinel_one] Add agent.id to all agent related data#10102
chrisberkhout merged 3 commits into
elastic:mainfrom
chrisberkhout:s1-agent-id

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

[sentinel_one] Add agent.id to all agent related data (#)

If the data is associated with a SentinelOne agent, include the agent's
ID in the final document, as `sentinel_one.<source_type>.agent.id`.

For the `agent` and `threat` data streams, the value was already stored
in `host.id`, but it was added to `sentinel_one.<source_type>.agent.id`.

For the `activity` data stream, this was already done.

For the `alert` data stream, no agent ID is available. There is a field
`agentDetectionInfo.uuid`, described in the documentation as the
"UUID of the agent", which seems to be a different value, and was
already stored in `observer.serial_number`.

For the `group` data stream there is no field that identifies an agent.

It's was already done in the activity data stream here.

I checked the SentinelOne API documentation to confirm that for each endpoint there weren't additional relevant fields in responses.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added enhancement New feature or request Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 7, 2024
@chrisberkhout chrisberkhout self-assigned this Jun 7, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner June 7, 2024 16:46
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @chrisberkhout

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisberkhout
chrisberkhout merged commit 28bca01 into elastic:main Jun 10, 2024
@elasticmachine

Copy link
Copy Markdown

Package sentinel_one - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=sentinel_one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants