ti_abusech: improve error handling and reporting in malwarebazaar data stream - #10156
Merged
Conversation
efd6
added
enhancement
efd6
force-pushed
the
10155-ti_abusech_errors
branch
from
June 16, 2024 22:43
db2f71a to
c0df915
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
cc @efd6 |
efd6
marked this pull request as ready for review
June 16, 2024 23:05
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
commented
Jun 17, 2024
| }).do_request().as(resp, resp.StatusCode == 200 ? | ||
| bytes(resp.Body).decode_json().as(body, body.?query_status.orValue("") == "ok" ? | ||
| { | ||
| "events": body.data.map(ind, { |
Contributor
Author
There was a problem hiding this comment.
This assumes that the API always responds sanely and that ok implies the data field is present.
|
Package ti_abusech - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_abusech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots