GCP: Redis Field Type Fix - #10159
Merged
Merged
Conversation
|
💚 CLA has been signed |
Member
|
@Linu-Elias : Please sign the CLA. |
ghost
assigned
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
ghost
approved these changes
Jun 17, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. Please make the changelog entry description a bit more descriptive.
|
/test |
ishleenk17
approved these changes
Jun 18, 2024
Contributor
Author
|
/test |
💚 Build Succeeded
History
cc @Linu-Elias |
|
|
Package gcp - 2.34.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
GCP Redis field
persistence.rdb.bgsave_in_progresshad incorrect type.This field was not used in the dashboards in the previous version.
Changed the GCP Redis field
persistence.rdb.bgsave_in_progresstype tobooleanChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
I've tested with elastic-package, and run the tests for the respective package.
Related issues
Screenshots