Skip to content

Prevent failure on not encoded url`s - #10226

Merged
efd6 merged 4 commits into
elastic:mainfrom
SimonKoetting:zscaler_decode_fix
Jun 25, 2024
Merged

Prevent failure on not encoded url`s#10226
efd6 merged 4 commits into
elastic:mainfrom
SimonKoetting:zscaler_decode_fix

Conversation

@SimonKoetting

Copy link
Copy Markdown
Contributor

In some cases, zscaler sents not encoded urls which den causes an parsing failure if the url contains e.g. a %

@SimonKoetting
SimonKoetting requested a review from a team as a code owner June 24, 2024 12:36
@elasticmachine

elasticmachine commented Jun 24, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

Package zscaler_zia 👍(1) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
tunnel 4830.92 4032.26 -798.66 (-16.53%) 💔

To see the full report comment with /test benchmark fullreport

@jamiehynds jamiehynds added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jun 24, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@jamiehynds jamiehynds added Integration:zscaler_zia Zscaler Internet Access enhancement New feature or request labels Jun 24, 2024
Comment thread packages/zscaler_zia/changelog.yml Outdated

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit.

Comment thread packages/zscaler_zia/changelog.yml Outdated
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@SimonKoetting
SimonKoetting requested a review from efd6 June 25, 2024 06:09

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6

efd6 commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@efd6
efd6 merged commit 50397dd into elastic:main Jun 25, 2024
@SimonKoetting
SimonKoetting deleted the zscaler_decode_fix branch June 25, 2024 06:45
@elasticmachine

Copy link
Copy Markdown

Package zscaler_zia - 2.20.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants