Skip to content

[Kubernetes Integration] Updating kubernetes volume dashboard - #10267

Merged
gizas merged 8 commits into
mainfrom
updating_kubernetes_volume_dashboard
Jul 17, 2024
Merged

[Kubernetes Integration] Updating kubernetes volume dashboard#10267
gizas merged 8 commits into
mainfrom
updating_kubernetes_volume_dashboard

Conversation

@gizas

@gizas gizas commented Jun 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

Proposed commit message

  • WHAT: Updating the Kubernetes Volume Dashboard to include Volume information per Pod
  • WHY: Adding more meaningful information because until now we were providing only general information for the volumes

Notes:

  • Volume % : Defined as Maximum value
  • A filter datastream.dataset=kubernetes.volume added in the visualisation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone this repo
  • cd to integrations/build/packages/kubernetes
  • Build latest integaration with elastic-package build
  • Create a new local elastic stack with elastic-package stack up -d -v --version=8.15.0-SNAPSHOT
  • Install K8s integration package (latest that this manifest defines is 1.61.2)
  • Navigate to Kubernete Volume Dashboard

Related issues

Screenshots

Screenshot 2024-06-26 at 12 13 22 PM

Screenshot 2024-06-26 at 12 13 44 PM
@gizas
gizas requested review from a team as code owners June 26, 2024 09:22
@elasticmachine

elasticmachine commented Jun 26, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
dej611
dej611 reviewed Jul 4, 2024
View reviewed changes
Comment thread packages/kubernetes/kibana/dashboard/kubernetes-3912d9a0-bcb2-11ec-b64f-7dd6e8e82013.json Outdated
Comment on lines +214 to +215
"indexpattern": {
"layers": {}

@dej611 dej611 Jul 4, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supposed to be here. How did you generate the panel?
Comment thread packages/kubernetes/kibana/dashboard/kubernetes-3912d9a0-bcb2-11ec-b64f-7dd6e8e82013.json Outdated
tetianakravchenko
tetianakravchenko reviewed Jul 5, 2024
View reviewed changes
Comment thread packages/kubernetes/changelog.yml Outdated
Comment thread packages/kubernetes/kibana/dashboard/kubernetes-3912d9a0-bcb2-11ec-b64f-7dd6e8e82013.json Outdated
Comment thread packages/kubernetes/changelog.yml Outdated
@tetianakravchenko

tetianakravchenko commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

@gizas there is smth wrong:
before this PR - there were 2 vizualisations:
Screenshot 2024-07-05 at 14 06 37

after - 3 with wrong formating, one of them is a duplication:
Screenshot 2024-07-05 at 14 08 20
@gizas
gizas requested a review from eedugon July 5, 2024 12:25
@tetianakravchenko

tetianakravchenko commented Jul 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

after clarification:

  1. please add a title for the new vizualisation - like Volume usage [Metrics Kubernetes] (similar to other names)
  2. clarify if pod name should be added to the Filesystem Inodes Informations [Metrics Kubernetes] and Filesystem Informations [Metrics Kubernetes] vizualisations as well
tetianakravchenko
tetianakravchenko reviewed Jul 5, 2024
View reviewed changes
Comment thread packages/kubernetes/changelog.yml Outdated
@gizas

gizas commented Jul 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@eedugon lets clarify above questions: #10267 (comment)
For me the Filesystem Innformation related Visulaisations are general and should remain like that and the first visualisation for pods is enough to have the categories you want. WDYT?

I have added title Volume Usage per Pod[Metrics Kubernetes]
tetianakravchenko
tetianakravchenko approved these changes Jul 8, 2024
View reviewed changes

@tetianakravchenko tetianakravchenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please clarify #10267 (comment) before merging.
@elasticmachine

elasticmachine commented Jul 17, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History
@elastic-sonarqube

elastic-sonarqube Bot commented Jul 17, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@gizas
gizas merged commit 74a1d90 into main Jul 17, 2024
@gizas

gizas commented Jul 17, 2024

Copy link
Copy Markdown
Contributor Author

Synced with @eedugon offline. There was a comment to change the filter of visualisation to metricset.name but we decide not. Reason was to keep it aligned as per other dashboards that have data_stream.dataset used.

This dashboard might need another update when the type of volume will be intorduced
@elasticmachine

elasticmachine commented Jul 17, 2024

Copy link
Copy Markdown

Package kubernetes - 1.66.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@gizas
[Kubernetes Integration] Updating kubernetes volume dashboard (elasti…
ad534fc 
…c#10267)

* adding volume usage per pod

* updating manifest and fixing references for controls

* updating manifest with pr and capitalising Labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:kubernetes Kubernetes

5 participants

@gizas @elasticmachine @tetianakravchenko @dej611 @andrewkroh