Skip to content

[aws] Add S3 option to s3access logs - #10460

Merged
kaiyan-sheng merged 7 commits into
elastic:mainfrom
kaiyan-sheng:s3access
Jul 18, 2024
Merged

[aws] Add S3 option to s3access logs#10460
kaiyan-sheng merged 7 commits into
elastic:mainfrom
kaiyan-sheng:s3access

Conversation

@kaiyan-sheng

@kaiyan-sheng kaiyan-sheng commented Jul 11, 2024

Copy link
Copy Markdown

Proposed commit message

This PR is to add reading logs directly from S3 as an option for s3access data stream. There are more data streams need this change, will add it later in the same PR.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Screenshot 2024-07-15 at 12 39 01 PM

I tested it with a sample log file just with content test1. It's not an s3acecss log so it shows it cant be parsed. But the message got ingested from s3 to elastic:
Screenshot 2024-07-17 at 6 31 03 PM

The agent policy looks like this:

inputs:
  - id: aws-s3-s3-e01b9c5e-c872-485d-81f3-d75a6ef534c9
    name: aws-1
    revision: 2
    type: aws-s3
    use_output: default
    meta:
      package:
        name: aws
        version: 3.0.0
    data_stream:
      namespace: default
    package_policy_id: e01b9c5e-c872-485d-81f3-d75a6ef534c9
    streams:
      - id: aws-s3-aws.s3access-e01b9c5e-c872-485d-81f3-d75a6ef534c9
        data_stream:
          dataset: aws.s3access
          type: logs
        bucket_arn: 'arn:aws:s3:::test-aws-s3-input-ks'
        number_of_workers: 5
        bucket_list_interval: 1m
        access_key_id: '${SECRET_0}'
        secret_access_key: '${SECRET_1}'
        session_token: '${SECRET_2}'
        tags:
          - forwarded
          - aws-s3access
        publisher_pipeline.disable_host: true
@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner July 11, 2024 23:19
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 11, 2024
@kaiyan-sheng
kaiyan-sheng requested review from a team as code owners July 11, 2024 23:29
Comment thread packages/aws/changelog.yml Outdated
@kaiyan-sheng
kaiyan-sheng requested a review from efd6 July 12, 2024 23:57
@elasticmachine

elasticmachine commented Jul 15, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

Package aws 👍(8) 💚(4) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
inspector 1805.05 1438.85 -366.2 (-20.29%) 💔
securityhub_findings 1102.54 900.09 -202.45 (-18.36%) 💔
waf 6849.32 5263.16 -1586.16 (-23.16%) 💔
apigateway_logs 11363.64 4065.04 -7298.6 (-64.23%) 💔
cloudwatch_logs 500000 250000 -250000 (-50%) 💔

To see the full report comment with /test benchmark fullreport

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/aws/data_stream/s3access/manifest.yml Outdated

@MichaelKatsoulis MichaelKatsoulis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kaiyan-sheng

@kaiyan-sheng
kaiyan-sheng enabled auto-merge (squash) July 18, 2024 18:04
@kaiyan-sheng
kaiyan-sheng merged commit 5c7d1a1 into elastic:main Jul 18, 2024
@elasticmachine

Copy link
Copy Markdown

Package aws - 2.20.0 containing this change is available at https://epr.elastic.co/search?package=aws

@kaiyan-sheng
kaiyan-sheng deleted the s3access branch July 18, 2024 20:52
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

7 participants