Skip to content

[AWS] update max_number_of_messages parameter description - #10480

Merged
kaiyan-sheng merged 7 commits into
elastic:mainfrom
kaiyan-sheng:max_number_of_messages
Aug 6, 2024
Merged

[AWS] update max_number_of_messages parameter description#10480
kaiyan-sheng merged 7 commits into
elastic:mainfrom
kaiyan-sheng:max_number_of_messages

Conversation

@kaiyan-sheng

@kaiyan-sheng kaiyan-sheng commented Jul 12, 2024

Copy link
Copy Markdown

Proposed commit message

This PR is to update the documentation for max_number_of_messages to inform users to be cautious when using a large value for this var.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • needs to make the same change in aws package
  • needs to make the same change in beats
@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner July 12, 2024 23:19
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 12, 2024
@andrewkroh andrewkroh added the Integration:aws_logs Custom AWS Logs label Jul 19, 2024
@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner July 24, 2024 19:02
colleenmcginnis
colleenmcginnis reviewed Jul 24, 2024
View reviewed changes
Comment thread packages/aws/data_stream/apigateway_logs/manifest.yml Outdated
@andrewkroh andrewkroh added Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 24, 2024
@elasticmachine

elasticmachine commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown

🚀 Benchmarks report

Package aws 👍(10) 💚(3) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
s3access 5376.34 3802.28 -1574.06 (-29.28%) 💔
vpcflow 8000 6369.43 -1630.57 (-20.38%) 💔
ec2_logs 41666.67 32258.06 -9408.61 (-22.58%) 💔
emr_logs 31250 12345.68 -18904.32 (-60.49%) 💔

To see the full report comment with /test benchmark fullreport
@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner July 25, 2024 17:34
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Aug 2, 2024
@elasticmachine

elasticmachine commented Aug 2, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@muthu-mps muthu-mps changed the title update max_number_of_messages parameter description Aug 2, 2024
muthu-mps
muthu-mps reviewed Aug 5, 2024
View reviewed changes

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we make the change across different AWS integrations where we have the max_number_of_messages input. The cloudfront logs has not been updated here. Do you consider updating cloudfront_logs as well?
@kaiyan-sheng

kaiyan-sheng commented Aug 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

As we make the change across different AWS integrations where we have the max_number_of_messages input. The cloudfront logs has not been updated here. Do you consider updating cloudfront_logs as well?

@muthu-mps Good catch! Thank you!!! I just updated it in the new commit.
@kaiyan-sheng
kaiyan-sheng requested a review from muthu-mps August 5, 2024 17:25
@elasticmachine

elasticmachine commented Aug 5, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kaiyan-sheng
@elastic-sonarqube

elastic-sonarqube Bot commented Aug 5, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
muthu-mps
muthu-mps approved these changes Aug 6, 2024
View reviewed changes

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@kaiyan-sheng
kaiyan-sheng merged commit 31ad9a6 into elastic:main Aug 6, 2024
@kaiyan-sheng
kaiyan-sheng deleted the max_number_of_messages branch August 6, 2024 17:04
@elasticmachine

elasticmachine commented Aug 6, 2024

Copy link
Copy Markdown

Package aws - 2.22.1 containing this change is available at https://epr.elastic.co/search?package=aws
@elasticmachine

elasticmachine commented Aug 6, 2024

Copy link
Copy Markdown

Package aws_logs - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=aws_logs
ltflb-bgdi pushed a commit to geoadmin/infra-elastic-integrations that referenced this pull request Sep 6, 2024
kaiyan-sheng @ltflb-bgdi
[AWS] update max_number_of_messages parameter description (elastic#10480
7b8d949 
)

This PR is to update the documentation for max_number_of_messages to inform users to be cautious when using a large value for this var.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
kaiyan-sheng
[AWS] update max_number_of_messages parameter description (elastic#10480
aeaa33e 
)

This PR is to update the documentation for max_number_of_messages to inform users to be cautious when using a large value for this var.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
kaiyan-sheng
[AWS] update max_number_of_messages parameter description (elastic#10480
cdfc018 
)

This PR is to update the documentation for max_number_of_messages to inform users to be cautious when using a large value for this var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws_logs Custom AWS Logs Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

8 participants

@kaiyan-sheng @elasticmachine @zmoog @gizas @colleenmcginnis @efd6 @muthu-mps @andrewkroh