Skip to content

[integrations][keycloak] - Fixed parser config default value and updated GROK pattern to account for multiline error logs - #10549

Merged
ShourieG merged 2 commits into
elastic:mainfrom
ShourieG:bugfix/keycloak
Jul 23, 2024
Merged

[integrations][keycloak] - Fixed parser config default value and updated GROK pattern to account for multiline error logs#10549
ShourieG merged 2 commits into
elastic:mainfrom
ShourieG:bugfix/keycloak

Conversation

@ShourieG

@ShourieG ShourieG commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

  1. The default parser regex pattern was faulty based on the parser requirements, hence updated it accordingly.
  2. The existing GROK pattern did not pick up multiline error logs, hence updated it accordingly and regenerated tests reflecting the change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • URL extention detections seems to have stopped after the change, and the extention is part of the url now.

NOTE:

I revisited the url extention issue and seems even after a revert the extension field is no longer generated. This seems it might not be related to this change but rather how url extensions are now handled in ecs. It seems only file extensions are parsed now instead of a ".path". (could be wrong)

How to test this PR locally

Related issues

Screenshots

@ShourieG
ShourieG requested a review from a team as a code owner July 22, 2024 13:26
@ShourieG ShourieG self-assigned this Jul 22, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jul 22, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue labels Jul 22, 2024
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

���� Build Succeeded

cc @ShourieG

@ShourieG
ShourieG requested a review from efd6 July 22, 2024 14:20
@ShourieG
ShourieG removed the request for review from efd6 July 23, 2024 05:38

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG
ShourieG merged commit 2c1ef36 into elastic:main Jul 23, 2024
@ShourieG
ShourieG deleted the bugfix/keycloak branch July 23, 2024 06:29
@elasticmachine

Copy link
Copy Markdown

Package keycloak - 1.22.1 containing this change is available at https://epr.elastic.co/search?package=keycloak

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…ted GROK pattern to account for multiline error logs (elastic#10549)

* Fixed parser config default value and updated GROK pattern to account for multiline logs

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:keycloak Keycloak integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants