Skip to content

[Kubernetes] Add both pod.{cpu,memory}.usage.node.pct and pod.{cpu,memory}.usage.limit.pct metrics to the Overview dashboard - #10593

Merged
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:k8s-overview-dashboard
Sep 10, 2024
Merged

[Kubernetes] Add both pod.{cpu,memory}.usage.node.pct and pod.{cpu,memory}.usage.limit.pct metrics to the Overview dashboard#10593
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:k8s-overview-dashboard

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before:
Screenshot 2024-07-25 at 11 47 31

Screenshot 2024-07-25 at 11 47 51

After:
Screenshot 2024-09-09 at 13 55 22

Screenshot 2024-07-25 at 12 07 50
…eats#39854

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

@mbondyra mbondyra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Integration:kubernetes Kubernetes Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Jul 25, 2024
@andrewkroh andrewkroh added the enhancement New feature or request label Aug 19, 2024
@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Aug 30, 2024
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Comment thread packages/kubernetes/changelog.yml Outdated
# newer versions go on top
- version: 1.67.0
changes:
- description: Adjust the Overview and Pods dashboards accordingly to https://github.com/elastic/beats/issues/39854

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Adjust the Overview and Pods dashboards accordingly to https://github.com/elastic/beats/issues/39854
- description: Adjust the Overview and Pods dashboards accordingly regarding pod.cpu.usage.node.pct. and pod.memory.usage.limit.pct

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to remove the pr as we dont use them in general.. wdyt?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gizas I've changed the description, since I've added both metrics to the overview - 80f3b2a

…dashboard

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@tetianakravchenko tetianakravchenko changed the title [Kubernetes] Adjust overview and pods dashboards corresponding to change https://github.com/elastic/beats/issues/39854 Sep 9, 2024
@tetianakravchenko
tetianakravchenko merged commit 0353d8c into elastic:main Sep 10, 2024
@tetianakravchenko
tetianakravchenko deleted the k8s-overview-dashboard branch September 10, 2024 07:47
@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.67.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…mory}.usage.limit.pct metrics to the Overview dashboard (elastic#10593)

* adjust overview and pods dashboards corresponding to change elastic/beats#39854

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix PR link

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add cpu/mem per Pod Limit and per Node; fix the link to the overview dashboard

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix the pr description

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…mory}.usage.limit.pct metrics to the Overview dashboard (elastic#10593)

* adjust overview and pods dashboards corresponding to change elastic/beats#39854

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix PR link

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add cpu/mem per Pod Limit and per Node; fix the link to the overview dashboard

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix the pr description

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:kubernetes Kubernetes Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]

6 participants