Skip to content

ti_abusech: Fix ECS date mapping on threat fields. - #10637

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:abusech-first_seen
Jul 30, 2024
Merged

ti_abusech: Fix ECS date mapping on threat fields.#10637
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:abusech-first_seen

Conversation

@kcreddy

@kcreddy kcreddy commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Fix ECS date mapping for threat fields.

ecs@mappings component template is missing threat fields 
mapped as date. Example: fields such as first_seen, last_seen, 
modified_at are being mapped as keyword in transform's source 
datastream-backed indices. The transform's destination indices
are not effected as they are not datastream-backed and mappings
are explicitly defined as date. This causes field type conflicts.

   - Explicitly add ECS threat fields that are of type date into 
     source data-stream backed fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kcreddy kcreddy self-assigned this Jul 29, 2024
@kcreddy kcreddy added Integration:ti_abusech abuse.ch bugfix Pull request that fixes a bug issue labels Jul 29, 2024
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kcreddy

@kcreddy
kcreddy marked this pull request as ready for review July 29, 2024 11:24
@kcreddy
kcreddy requested a review from a team as a code owner July 29, 2024 11:25
@kcreddy kcreddy added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jul 29, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change in ingest and tests since these fields are already handled there; this just ensures correct mapping.

@kcreddy
kcreddy merged commit 1ef788e into elastic:main Jul 30, 2024
@elasticmachine

Copy link
Copy Markdown

Package ti_abusech - 2.3.1 containing this change is available at https://epr.elastic.co/search?package=ti_abusech

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Fix ECS date mapping for threat fields.

ecs@mappings component template is missing threat fields 
mapped as date. Example: fields such as first_seen, last_seen, 
modified_at are being mapped as keyword in transform's source 
datastream-backed indices. The transform's destination indices
are not effected as they are not datastream-backed and mappings
are explicitly defined as date. This causes field type conflicts.

   - Explicitly add ECS threat fields that are of type date into 
     source data-stream backed fields
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Fix ECS date mapping for threat fields.

ecs@mappings component template is missing threat fields 
mapped as date. Example: fields such as first_seen, last_seen, 
modified_at are being mapped as keyword in transform's source 
datastream-backed indices. The transform's destination indices
are not effected as they are not datastream-backed and mappings
are explicitly defined as date. This causes field type conflicts.

   - Explicitly add ECS threat fields that are of type date into 
     source data-stream backed fields
@kcreddy
kcreddy deleted the abusech-first_seen branch February 7, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:ti_abusech abuse.ch Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants