Skip to content

vsphere: Add support for processors in datastore, host and virtualmachine - #10664

Merged
ishleenk17 merged 4 commits into
elastic:mainfrom
bene-dt0:add-vsphere-datastore-host-and-virtualmachine-processors
Sep 18, 2024
Merged

vsphere: Add support for processors in datastore, host and virtualmachine#10664
ishleenk17 merged 4 commits into
elastic:mainfrom
bene-dt0:add-vsphere-datastore-host-and-virtualmachine-processors

Conversation

@bene-dt0

@bene-dt0 bene-dt0 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Adds processor support for the datastore, host and virtual machine metrics data stream within the vSphere integration since it is missing for this integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Availability of Processor fields under datastore, host, and virtualmachine within the vSphere Integration
@bene-dt0
bene-dt0 requested a review from a team as a code owner July 31, 2024 12:13
@ishleenk17

Copy link
Copy Markdown
Member

/test

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 2, 2024
@andrewkroh andrewkroh added the enhancement New feature or request label Aug 19, 2024
@bene-dt0

Copy link
Copy Markdown
Contributor Author

Hey. Are there any updates on this PR? Is there a timeframe available? Thanks

@ishleenk17

Copy link
Copy Markdown
Member

/test

@ishleenk17

Copy link
Copy Markdown
Member

Hey. Are there any updates on this PR? Is there a timeframe available? Thanks

Hey. Are there any updates on this PR? Is there a timeframe available? Thanks

The changes look good. Triggered CI. Once that passes, we are GTG.

@shmsr shmsr changed the title Add support for processors on vsphere datastore, host and virtualmachine Sep 16, 2024
Comment thread packages/vsphere/changelog.yml Outdated

@shmsr shmsr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment; rest looks good! Thanks for your contribution @bene-dt0! 🎉

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@ishleenk17

Copy link
Copy Markdown
Member

We are going to have some big enhancements added to vSphere Integration.
So would be merging this community contribution before those go in.

@ishleenk17

Copy link
Copy Markdown
Member

/test

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @bene-dt0

@ishleenk17
ishleenk17 merged commit a05a2b1 into elastic:main Sep 18, 2024
@bene-dt0
bene-dt0 deleted the add-vsphere-datastore-host-and-virtualmachine-processors branch September 20, 2024 08:21
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…hine (elastic#10664)

* Add support for processors on vsphere datastore, host and virtualmachine integrations and remove empty lines

* Update changelog link

* Update packages/vsphere/changelog.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…hine (elastic#10664)

* Add support for processors on vsphere datastore, host and virtualmachine integrations and remove empty lines

* Update changelog link

* Update packages/vsphere/changelog.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants