Skip to content

[zscaler_zia] Update response format version numbers - #10741

Merged
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:zscaler-zia-response-format-versions-fix
Aug 8, 2024
Merged

[zscaler_zia] Update response format version numbers#10741
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:zscaler-zia-response-format-versions-fix

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Aug 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

[zscaler_zia] Update response format version numbers (#)

Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@chrisberkhout
Correct response format versions.
b8e8e4f 
| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
@chrisberkhout chrisberkhout added Integration:zscaler_zia Zscaler Internet Access bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 8, 2024
@chrisberkhout chrisberkhout self-assigned this Aug 8, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner August 8, 2024 12:55
@elasticmachine

elasticmachine commented Aug 8, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
kcreddy
kcreddy approved these changes Aug 8, 2024
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion. LGTM Otherwise 👍🏼
Thanks for taking care of this!
Comment thread packages/zscaler_zia/_dev/build/docs/README.md
Comment thread packages/zscaler_zia/_dev/build/docs/README.md
@elasticmachine

elasticmachine commented Aug 8, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Aug 8, 2024

Copy link
Copy Markdown

💚 Build Succeeded

cc @chrisberkhout
@elastic-sonarqube

elastic-sonarqube Bot commented Aug 8, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@chrisberkhout
chrisberkhout merged commit 7b5d67c into elastic:main Aug 8, 2024
@chrisberkhout
chrisberkhout deleted the zscaler-zia-response-format-versions-fix branch August 8, 2024 13:35
@elasticmachine

elasticmachine commented Aug 8, 2024

Copy link
Copy Markdown

Package zscaler_zia - 3.0.4 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@chrisberkhout
[zscaler_zia] Update response format version numbers (elastic#10741)
cc542d0 
Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@chrisberkhout
[zscaler_zia] Update response format version numbers (elastic#10741)
299dee5 
Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
@chrisberkhout chrisberkhout mentioned this pull request May 22, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@chrisberkhout @elasticmachine @kcreddy