[cisco_ise] Improve handling of unset fields from source - #10754
Merged
Conversation
Improve the handling of unset/null data fields, by checking for null before using the data in more processors. Some log messages do not set all expected fields. This adds more checks that data is not null attempting to run processors on these fields. This also adds some examples of log messages that do not populate some datafields to the pipeline tests.
andrewkroh
added
Integration:cisco_ise
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
reviewed
Aug 9, 2024
…ne/pipeline_passed_authentications.yml Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
mjwolf
enabled auto-merge (squash)
August 9, 2024 23:58
Contributor
Author
|
I don't Sonarqube is calculating coverage correctly for this, it's saying at least two blocks are uncovered, when testcases exist with data for them ( |
…ns into cisco-ise-handle-nulls
mjwolf
force-pushed
the
cisco-ise-handle-nulls
branch
from
August 14, 2024 18:22
8a3f638 to
b5184ea
Compare
💚 Build Succeeded
History
cc @mjwolf |
|
taylor-swanson
approved these changes
Aug 14, 2024
|
Package cisco_ise - 1.22.4 containing this change is available at https://epr.elastic.co/search?package=cisco_ise |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Improve the handling of unset/null data fields, by checking for null before using the data in more processors. Some log messages do not set all expected fields. This adds more checks that data is not null attempting to run processors on these fields. This also adds some examples of log messages that do not populate some datafields to the pipeline tests. --------- Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Improve the handling of unset/null data fields, by checking for null before using the data in more processors. Some log messages do not set all expected fields. This adds more checks that data is not null attempting to run processors on these fields. This also adds some examples of log messages that do not populate some datafields to the pipeline tests. --------- Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Improve the handling of unset/null data fields, by checking for null before using the data in processors.
Some log messages do not set all expected fields. This adds more checks that data is not null attempting to run processors on these fields. This also adds some examples of log messages that do not populate some datafields to the pipeline tests.
Checklist
changelog.ymlfile.