Skip to content

M365_defender bug fix: add check for - in host.mac - #10798

Merged
efd6 merged 2 commits into
elastic:mainfrom
peterydzynski:m365-defender-gsub-fix
Aug 15, 2024
Merged

M365_defender bug fix: add check for - in host.mac#10798
efd6 merged 2 commits into
elastic:mainfrom
peterydzynski:m365-defender-gsub-fix

Conversation

@peterydzynski

Copy link
Copy Markdown
Contributor

Proposed commit message

M365 Defender has started to send logs where the MAC address already has -'s. This breaks the gsub processor that is expecting the old format where MAC addresses have no -'s . I added a conditional check for this processor so that it only runs if it encounters a MAC address without -'s in it.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@peterydzynski
peterydzynski requested a review from a team as a code owner August 14, 2024 22:31
@andrewkroh andrewkroh added Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 14, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6

efd6 commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit 490196f into elastic:main Aug 15, 2024
@elasticmachine

Copy link
Copy Markdown

Package m365_defender - 2.14.4 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@peterydzynski
peterydzynski deleted the m365-defender-gsub-fix branch August 15, 2024 14:26
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
M365 Defender has started to send logs where the MAC address already has '-'s.
This breaks the gsub processor that is expecting the old format where MAC
addresses have no '-'. Add a conditional check for this processor so that it
only runs if it encounters a MAC address without '-'s in it.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
M365 Defender has started to send logs where the MAC address already has '-'s.
This breaks the gsub processor that is expecting the old format where MAC
addresses have no '-'. Add a conditional check for this processor so that it
only runs if it encounters a MAC address without '-'s in it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants