[panw] Fix x-fwd-for parsing - #10816
Merged
Merged
Conversation
dwhyrock
marked this pull request as ready for review
August 19, 2024 20:16
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
pkoutsovasilis
left a comment
Contributor
There was a problem hiding this comment.
changelog and manifest updates?
taylor-swanson
approved these changes
Aug 20, 2024
|
💚 Build Succeeded
History
cc @dwhyrock |
|
Package panw - 4.0.1 containing this change is available at https://epr.elastic.co/search?package=panw |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* Apply Taylor's change * completing taylor's change * Add logs and expected logs * Take out the x-fwd-for string * Update expected logs * updating to allowed geo IPs * Add more unique logs * Adding manifest and changelog updates * Adding comment to default.yml * Made changelog description more specific
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* Apply Taylor's change * completing taylor's change * Add logs and expected logs * Take out the x-fwd-for string * Update expected logs * updating to allowed geo IPs * Add more unique logs * Adding manifest and changelog updates * Adding comment to default.yml * Made changelog description more specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposed commit message
Moving src/dst user processing to down around the labels processors, and added a rename processor in between. This allows the
x-fwd-forprocessing to now function correctly.Thanks to @taylor-swanson for figuring out the issue and creating the initial change.
Checklist
changelog.ymlfile.Author's Checklist
x_forwarded_forvalue havex-fwd-forstring in it? (e.g.,"x_forwarded_for": "x-fwd-for: 10.34.32.4")How to test this PR locally
Related issues
Screenshots
Snippets before the change:
Snippets after the change