Add back custom.yml files to LotL, DGA packages - #10823
Merged
Merged
Conversation
andrewkroh
added
Integration:dga
sodhikirti07
approved these changes
Aug 20, 2024
Member
|
Thanks Gus! In this PR description, can you also link the PRs where the files were previously removed, for documentation purposes? |
💚 Build Succeeded
History
cc @jmcarlock |
|
Contributor
Author
|
@susan-shu-c here's the original PR |
Contributor
Author
|
susan-shu-c
approved these changes
Aug 20, 2024
qn895
approved these changes
Aug 20, 2024
Contributor
Author
|
Thank you @susan-shu-c @sodhikirti07 @qn895 for the quick review! |
|
Package dga - 2.0.4 containing this change is available at https://epr.elastic.co/search?package=dga |
|
Package problemchild - 2.1.5 containing this change is available at https://epr.elastic.co/search?package=problemchild |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* Add back custom.yml files to LotL, DGA packages * add to changelog, bump package manifest version * add `base-fields.yml` to pass tests
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* Add back custom.yml files to LotL, DGA packages * add to changelog, bump package manifest version * add `base-fields.yml` to pass tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Adds
fields/custom.ymlfiles back to the DGA and Living off the Land (ProblemChild) integration packages. These files are used for integration testing done upstream.Checklist
I have verified that all data streams collect metrics or logs.Not neededchangelog.ymlfile.Author's Checklist
elastic-packageHow to test this PR locally
Build with
elastic-package.Related issues