Skip to content

[Amazon Security Lake] - Re-enable SQS notification settings - #10854

Merged
ShourieG merged 9 commits into
elastic:mainfrom
ShourieG:bugfix/security_lake_revert
Aug 26, 2024
Merged

[Amazon Security Lake] - Re-enable SQS notification settings #10854
ShourieG merged 9 commits into
elastic:mainfrom
ShourieG:bugfix/security_lake_revert

Conversation

@ShourieG

@ShourieG ShourieG commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

SQS notification config settings were removed due to an internal update error in this PR. This caused successive confusing documentation issues that were resolved in this PR. All of this was unnecessary and the original removal was an error in itself and this PR tries to rectify this mistake and make it easier for users to use the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG
ShourieG requested a review from a team as a code owner August 22, 2024 14:35
@ShourieG ShourieG self-assigned this Aug 22, 2024
@ShourieG ShourieG added the bugfix Pull request that fixes a bug issue label Aug 22, 2024
@andrewkroh andrewkroh added Integration:amazon_security_lake Amazon Security Lake Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 22, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] and removed Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 22, 2024
@ShourieG
ShourieG requested a review from andrewkroh August 22, 2024 14:38
@ShourieG ShourieG changed the title Bugfix/security lake revert Aug 22, 2024
@andrewkroh

Copy link
Copy Markdown
Contributor

I think we can help clarify how file_selectors should be used to consume parquet files be adding a default value to the variable with a YAML example (possibly commented out if it's not a good default for all users?).

@ShourieG

Copy link
Copy Markdown
Contributor Author

@andrewkroh, updated with a commented out example in the default settings for file selectors.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @ShourieG

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@ShourieG
ShourieG merged commit c35bd82 into elastic:main Aug 26, 2024
@ShourieG
ShourieG deleted the bugfix/security_lake_revert branch August 26, 2024 09:35
@elasticmachine

Copy link
Copy Markdown

Package amazon_security_lake - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…#10854)

* remove wrongly implemented sqs support from amazon security lake package

* updated changelog

* addressed PR comments

* reverted sqs notification removal commit

* updated docs

* updated changelog

* added example config for file selector config showing selective parquet decoding
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…#10854)

* remove wrongly implemented sqs support from amazon security lake package

* updated changelog

* addressed PR comments

* reverted sqs notification removal commit

* updated docs

* updated changelog

* added example config for file selector config showing selective parquet decoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:amazon_security_lake Amazon Security Lake Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants