[checkpoint] Improve normalization of user.name field - #10896
Merged
aleksmaus merged 4 commits intoSep 9, 2024
Merged
Conversation
andrewkroh
added
Integration:checkpoint
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
Contributor
Author
|
@mjwolf I addressed your suggestions, could you please take another look? |
|
💚 Build Succeeded
History
cc @aleksmaus |
|
Package checkpoint - 1.33.1 containing this change is available at https://epr.elastic.co/search?package=checkpoint |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* [checkpoint] Improve normalization of user.name field * Updated changelog with PR number * Address code review feedback
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* [checkpoint] Improve normalization of user.name field * Updated changelog with PR number * Address code review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Improve normalization of user.name field
Addressing this proposal
#10191
Using a different approach, since the
renameprocessors sequence with condition, lead to cases where thecheckoutfields sometimes are deleted and in some cases are left behind, depending on the target field condition.Making it consistent, changed
renameto thesetprocessors and preserving the originalcheckpointuser related fields. Added mappings for"administrator"and"src_user_name"fields (we already had"dst_user_name"preserved btw).Checklist
changelog.ymlfile.Related issues