Skip to content

[zscaler_zia] Improve data processing in the web pipeline - #10968

Merged
chrisberkhout merged 5 commits into
elastic:mainfrom
chrisberkhout:zscaler_zia-more-data-fixes
Sep 9, 2024
Merged

[zscaler_zia] Improve data processing in the web pipeline#10968
chrisberkhout merged 5 commits into
elastic:mainfrom
chrisberkhout:zscaler_zia-more-data-fixes

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

[zscaler_zia] Improve data processing in the web pipeline (#)

- If the `login` isn't an email address, use it all as `user.name`.
- Encode `%` characters in hex-encoded fields, so they can be decoded
  successfully with the URL decode processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@chrisberkhout
chrisberkhout requested a review from a team as a code owner September 2, 2024 15:37
@chrisberkhout chrisberkhout self-assigned this Sep 2, 2024
@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Sep 2, 2024
@elasticmachine

elasticmachine commented Sep 2, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@chrisberkhout chrisberkhout added Integration:zscaler_zia Zscaler Internet Access bugfix Pull request that fixes a bug issue labels Sep 2, 2024
@elasticmachine

elasticmachine commented Sep 3, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
efd6
efd6 reviewed Sep 3, 2024
View reviewed changes
Comment thread packages/zscaler_zia/data_stream/web/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/zscaler_zia/data_stream/web/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/zscaler_zia/data_stream/web/elasticsearch/ingest_pipeline/default.yml Outdated
@chrisberkhout
chrisberkhout requested a review from efd6 September 4, 2024 15:45
kcreddy
kcreddy approved these changes Sep 6, 2024
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a test to check the behaviour.
LGTM otherwise 👍🏼
@elasticmachine

elasticmachine commented Sep 9, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #15469 succeeded 6a4771bb88a2808515deaf776818bfb659493b0d
  • 💚 Build #15372 succeeded 79bd5d3031752b9e327c02a11e518096f3ceb954
  • 💚 Build #15357 succeeded a8403440a6225c09c99d4037e5cb5f6a2607cc50
  • 💚 Build #15352 succeeded 615272f6a01299fcb3cffd60fce437a26cf7f11d
  • 💔 Build #15320 failed 67296c8e7502cd9844021f3605b17cdae4f1064f

cc @chrisberkhout
@elastic-sonarqube

elastic-sonarqube Bot commented Sep 9, 2024

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
72.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube
@chrisberkhout
chrisberkhout merged commit b8675ca into elastic:main Sep 9, 2024
@chrisberkhout
chrisberkhout deleted the zscaler_zia-more-data-fixes branch September 9, 2024 13:31
@elasticmachine

elasticmachine commented Sep 9, 2024

Copy link
Copy Markdown

Package zscaler_zia - 3.2.4 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@chrisberkhout
[zscaler_zia] Improve data processing in the web pipeline (elastic#10968
8180c20 
)

- If the `login` isn't an email address, use it all as `user.name`.
- Encode `%` characters in hex-encoded fields, so they can be decoded
  successfully with the URL decode processor.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@chrisberkhout
[zscaler_zia] Improve data processing in the web pipeline (elastic#10968
81af898 
)

- If the `login` isn't an email address, use it all as `user.name`.
- Encode `%` characters in hex-encoded fields, so they can be decoded
  successfully with the URL decode processor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@chrisberkhout @elasticmachine @kcreddy @efd6