Skip to content

[vSphere] Add new resourcepool datatastream - #10996

Merged
ishleenk17 merged 10 commits into
elastic:mainfrom
niraj-elastic:vsphere_resourcepool_datastream
Sep 19, 2024
Merged

[vSphere] Add new resourcepool datatastream#10996
ishleenk17 merged 10 commits into
elastic:mainfrom
niraj-elastic:vsphere_resourcepool_datastream

Conversation

@niraj-elastic

@niraj-elastic niraj-elastic commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Added 1 data stream (Resourcepool Metrics).
  • Added data collection metrics for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/vsphere) directory.
  • Run the following command to run tests. elastic-package test

TSDS tool kit output

unnamed (9)

Related issues
@niraj-elastic niraj-elastic self-assigned this Sep 4, 2024
@andrewkroh andrewkroh added enhancement New feature or request Integration:vsphere VMware vSphere labels Sep 4, 2024
lucian-ioan
lucian-ioan reviewed Sep 11, 2024
View reviewed changes
Comment thread packages/vsphere/data_stream/resourcepool/manifest.yml
lucian-ioan
lucian-ioan reviewed Sep 11, 2024
View reviewed changes
Comment thread packages/vsphere/manifest.yml
lucian-ioan
lucian-ioan reviewed Sep 11, 2024
View reviewed changes
Comment thread packages/vsphere/data_stream/resourcepool/fields/fields.yml Outdated
lucian-ioan
lucian-ioan reviewed Sep 11, 2024
View reviewed changes
Comment thread packages/vsphere/changelog.yml Outdated
@niraj-elastic
niraj-elastic marked this pull request as ready for review September 19, 2024 08:07
@niraj-elastic
niraj-elastic requested a review from a team as a code owner September 19, 2024 08:07
@niraj-crest
Merge branch 'main' of https://github.com/niraj-elastic/integrations …
1ccc9eb 
…into vsphere_resourcepool_datastream

Conflicts:
	packages/vsphere/changelog.yml
@niraj-crest
add triggered_alarm
8f127a2
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Sep 19, 2024
ishleenk17
ishleenk17 reviewed Sep 19, 2024
View reviewed changes
Comment thread packages/vsphere/data_stream/resourcepool/_dev/test/pipeline/test-common-config.yml Outdated
ishleenk17
ishleenk17 reviewed Sep 19, 2024
View reviewed changes
Comment thread packages/vsphere/changelog.yml Outdated
Comment thread packages/vsphere/_dev/build/docs/README.md
@niraj-crest
Merge branch 'main' of https://github.com/niraj-elastic/integrations …
04e4eca 
…into vsphere_resourcepool_datastream

Conflicts:
	packages/vsphere/_dev/build/docs/README.md
	packages/vsphere/changelog.yml
	packages/vsphere/docs/README.md
@niraj-crest
update changelog
70ea808
kush-elastic
kush-elastic approved these changes Sep 19, 2024
View reviewed changes

@kush-elastic kush-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
lucian-ioan
lucian-ioan approved these changes Sep 19, 2024
View reviewed changes

@lucian-ioan lucian-ioan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
ishleenk17
ishleenk17 reviewed Sep 19, 2024
View reviewed changes
Comment thread packages/vsphere/_dev/build/docs/README.md Outdated
Comment thread packages/vsphere/_dev/build/docs/README.md
ishleenk17
ishleenk17 reviewed Sep 19, 2024
View reviewed changes
Comment thread packages/vsphere/_dev/build/docs/README.md Outdated
ishleenk17
ishleenk17 approved these changes Sep 19, 2024
View reviewed changes

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Let the CI pass
@elastic-sonarqube

elastic-sonarqube Bot commented Sep 19, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Sep 19, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @niraj-elastic
@ishleenk17
ishleenk17 merged commit 40459dc into elastic:main Sep 19, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Package vsphere - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=vsphere
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@niraj-elastic @niraj-crest
[vSphere] Add new resourcepool datatastream (elastic#10996)
03bc8e8 
* add resourcepool datastream

* Update changelog

* address review comments

* add triggered_alarm

* address review comments

* update changelog

* address review comment

* address review comment

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@niraj-elastic @niraj-crest
[vSphere] Add new resourcepool datatastream (elastic#10996)
f9682a8 
* add resourcepool datastream

* Update changelog

* address review comments

* add triggered_alarm

* address review comments

* update changelog

* address review comment

* address review comment

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

7 participants

@niraj-elastic @elasticmachine @lucian-ioan @kush-elastic @ishleenk17 @andrewkroh @niraj-crest