Skip to content

[netflow] add workers option - #11025

Merged
andrewkroh merged 5 commits into
elastic:mainfrom
pkoutsovasilis:pkoutsovasilis/netflow_workers
Nov 19, 2024
Merged

[netflow] add workers option#11025
andrewkroh merged 5 commits into
elastic:mainfrom
pkoutsovasilis:pkoutsovasilis/netflow_workers

Conversation

@pkoutsovasilis

@pkoutsovasilis pkoutsovasilis commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

This PR exposes the workers config option introduced in netflow filebeat input which will be available when 8.16.0 version is released

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test system

Related issues

Screenshots

image
@pkoutsovasilis pkoutsovasilis added enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Sep 6, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Sep 6, 2024
@pkoutsovasilis
pkoutsovasilis force-pushed the pkoutsovasilis/netflow_workers branch from 5942034 to 63b8bfa Compare September 6, 2024 09:31
@elasticmachine

elasticmachine commented Sep 6, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Sep 6, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@pkoutsovasilis

pkoutsovasilis commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

@andrewkroh given that this field is only available from 8.16.0 and onwards, I am not sure if should merge this PR before we get closer to the release date of the former. It would be way easier if we could define the minimum stack version for fields in the manifest and in the policy handlebars file of each datastream but this is not available (maybe it is worth investigating support for such a feature?!). So any ideas how to proceed here?
@botelastic

botelastic Bot commented Oct 19, 2024

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic Bot added the Stalled label Oct 19, 2024
@botelastic botelastic Bot removed the Stalled label Nov 7, 2024
@andrewkroh
andrewkroh marked this pull request as ready for review November 7, 2024 19:21
@andrewkroh
andrewkroh requested a review from a team as a code owner November 7, 2024 19:21
@elasticmachine

elasticmachine commented Nov 7, 2024

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)
@andrewkroh
netflow/changelog.yml - indicate that 8.16 is needed
6f08d00 
The feature will only take effect if you have upgraded
to elastic agent 8.16.0. Otherwise the setting is ignored.
@andrewkroh

andrewkroh commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

Setting this as ready for review because we are approaching the 8.16.0 release.
andrewkroh
andrewkroh reviewed Nov 7, 2024
View reviewed changes
Comment thread packages/netflow/data_stream/log/manifest.yml Outdated
@elasticmachine

elasticmachine commented Nov 7, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @jrmolin @pkoutsovasilis
@elastic-sonarqube

elastic-sonarqube Bot commented Nov 7, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@andrewkroh
andrewkroh merged commit 69fd5a2 into elastic:main Nov 19, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Package netflow - 2.20.0 containing this change is available at https://epr.elastic.co/package/netflow/2.20.0/
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@pkoutsovasilis @andrewkroh @flexitrev
[netflow] add workers option (#11025)
841f5ab 
This exposes the `workers` config option introduced in netflow 
filebeat input and is available in `>=8.16.0`.

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@pkoutsovasilis @andrewkroh
[netflow] add workers option (elastic#11025)
28afe01 
This exposes the `workers` config option introduced in netflow 
filebeat input and is available in `>=8.16.0`.

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@pkoutsovasilis @andrewkroh @flexitrev
[netflow] add workers option (#11025)
15732a3 
This exposes the `workers` config option introduced in netflow 
filebeat input and is available in `>=8.16.0`.

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@pkoutsovasilis @andrewkroh
[netflow] add workers option (elastic#11025)
de65d1e 
This exposes the `workers` config option introduced in netflow 
filebeat input and is available in `>=8.16.0`.

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants

@pkoutsovasilis @elasticmachine @andrewkroh @mjwolf @jrmolin