Skip to content

[carbon_black_cloud] Return full state in CEL program results - #11046

Merged
chrisberkhout merged 5 commits into
elastic:mainfrom
chrisberkhout:carbon_black_cloud-echo-api-key
Sep 10, 2024
Merged

[carbon_black_cloud] Return full state in CEL program results#11046
chrisberkhout merged 5 commits into
elastic:mainfrom
chrisberkhout:carbon_black_cloud-echo-api-key

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

[carbon_black_cloud] Return full state in CEL program results

Returning state with relevant field overridden resolves the problem of
losing `state.api_key` for later evaluations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@chrisberkhout chrisberkhout added Integration:carbon_black_cloud VMware Carbon Black Cloud bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 9, 2024
@chrisberkhout
chrisberkhout requested a review from efd6 September 9, 2024 14:53
@chrisberkhout chrisberkhout self-assigned this Sep 9, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner September 9, 2024 14:53
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest just wrapping the entire program with state.with() in both cases.

@chrisberkhout
chrisberkhout requested a review from efd6 September 10, 2024 09:41
@chrisberkhout

Copy link
Copy Markdown
Contributor Author

Wrapped the whole program as suggested.
Also applied celfmt.

@chrisberkhout
chrisberkhout enabled auto-merge (squash) September 10, 2024 09:43
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @chrisberkhout

@chrisberkhout
chrisberkhout merged commit 859a52a into elastic:main Sep 10, 2024
@elasticmachine

Copy link
Copy Markdown

Package carbon_black_cloud - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

@chrisberkhout
chrisberkhout deleted the carbon_black_cloud-echo-api-key branch September 11, 2024 08:34
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…c#11046)

[carbon_black_cloud] Return full state in CEL program results

Returning state with relevant field overridden resolves the problem of
losing `state.api_key` for later evaluations.

Also tidied up formatting.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…c#11046)

[carbon_black_cloud] Return full state in CEL program results

Returning state with relevant field overridden resolves the problem of
losing `state.api_key` for later evaluations.

Also tidied up formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:carbon_black_cloud VMware Carbon Black Cloud Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants