Skip to content

[Cloud Security] Added deployment_mode and properties CSPM, Elastic Connector - #11203

Closed
seanrathier wants to merge 4 commits into
elastic:mainfrom
seanrathier:304-label-the-cloud-security-integration-package
Closed

[Cloud Security] Added deployment_mode and properties CSPM, Elastic Connector#11203
seanrathier wants to merge 4 commits into
elastic:mainfrom
seanrathier:304-label-the-cloud-security-integration-package

Conversation

@seanrathier

@seanrathier seanrathier commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

We are updating the elastic-connector and the cloud-security-posture integrations to package-spec version 3.2.3 so that when deployment_mode agentless is selected we can pass the org, division and team information to the Agentless-API.

This will only be merged when package-spec version 3.2.3 is released.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Add a CSPM integration

Related issues

@seanrathier seanrathier changed the title Added deployment_mode and properties Sep 20, 2024
@andrewkroh andrewkroh added Integration:cloud_security_posture Security Posture Management Integration:elastic_connectors Elastic Connectors labels Sep 20, 2024
@seanrathier seanrathier changed the title [Cloud Security] Added deployment_mode and properties CSPM, Okta, Elastic Connector Sep 23, 2024
@seanrathier seanrathier added breaking change enhancement New feature or request and removed breaking change labels Oct 10, 2024
@seanrathier
seanrathier marked this pull request as ready for review October 10, 2024 21:20
@seanrathier
seanrathier requested a review from a team October 10, 2024 21:20
@seanrathier
seanrathier requested a review from a team as a code owner October 10, 2024 21:20
@seanrathier seanrathier self-assigned this Oct 10, 2024
@andrewkroh andrewkroh added Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:Search-Extract and Transform Search - Extract and Transform team [elastic/search-extract-and-transform] labels Oct 10, 2024
@seanrathier

Copy link
Copy Markdown
Contributor Author

When version 3.2.3 gets released next week, the CI should pass, and we should be able to merge.

Comment thread packages/cloud_security_posture/changelog.yml Outdated
Comment thread packages/cloud_security_posture/changelog.yml Outdated
Comment thread packages/elastic_connectors/changelog.yml Outdated
Comment thread packages/elastic_connectors/manifest.yml Outdated
@seanrathier
seanrathier force-pushed the 304-label-the-cloud-security-integration-package branch from af1b249 to b0d21fd Compare October 11, 2024 20:43
@seanrathier
seanrathier requested review from a team as code owners October 11, 2024 20:43
link: https://github.com/elastic/integrations/pull/11274
- version: "1.11.0-preview08"
changes:
- description: Added deployment_mode agentless to the policy template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this changelog entry as you added it to a new version

link: https://github.com/elastic/integrations/pull/11267
- version: 0.0.1
changes:
- description: Added owner information when deployment_mode has agentless enabled

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

@maxcold maxcold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanrathier seems like some old code hasn't been removed, pls check

enabled: true
organization: elastic
division: engineering
team: ingestion-team

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understood the review comment correctly the ask was to change ingestion-team to search-extract-and-transform but now we have both for some reason

@maxcold
maxcold self-requested a review October 14, 2024 16:14
@elasticmachine

elasticmachine commented Oct 14, 2024

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

cc @seanrathier

@jsoriano

Copy link
Copy Markdown
Contributor

This change is co-dependant of #11400, we will merge both changes together in the other PR. Thanks!

@mrodm

mrodm commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

@seanrathier @maxcold #11400 has already been merged. I think this PR can be closed.

@maxcold maxcold closed this Oct 15, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cloud_security_posture - 1.11.0-preview11 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package elastic_connectors - 0.0.3 containing this change is available at https://epr.elastic.co/search?package=elastic_connectors

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cloud_security_posture - 1.11.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.11.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cloud_security_posture Security Posture Management Integration:elastic_connectors Elastic Connectors Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:Search-Extract and Transform Search - Extract and Transform team [elastic/search-extract-and-transform]

8 participants