Skip to content

[vSphere] Filter alerts and warnings from triggered alarms. - #11230

Merged
niraj-elastic merged 7 commits into
elastic:mainfrom
niraj-elastic:vsphere_triggered_alarms
Sep 25, 2024
Merged

[vSphere] Filter alerts and warnings from triggered alarms.#11230
niraj-elastic merged 7 commits into
elastic:mainfrom
niraj-elastic:vsphere_triggered_alarms

Conversation

@niraj-elastic

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Updated pipeline with painless script to filter alerts and warnings from triggered alarms for all the datastreams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/vsphere) directory.
  • Run the following command to run tests. elastic-package test

Related issue

@andrewkroh andrewkroh added enhancement New feature or request Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Sep 24, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

niraj-elastic and others added 3 commits September 24, 2024 15:54
…into vsphere_triggered_alarms

Conflicts:
	packages/vsphere/changelog.yml

@kush-elastic kush-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucian-ioan lucian-ioan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/vsphere/data_stream/resourcepool/fields/fields.yml Outdated
Comment thread packages/vsphere/data_stream/resourcepool/fields/fields.yml Outdated
@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
48.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@niraj-elastic
niraj-elastic merged commit 52c05b0 into elastic:main Sep 25, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package vsphere - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=vsphere

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…11230)

* add alerts and warnings

* update changelog

* remove null fields

* update pipeline

* address review comments

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…11230)

* add alerts and warnings

* update changelog

* remove null fields

* update pipeline

* address review comments

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

7 participants