[carbon_black_cloud] Fix alert_v7 CEL pagination logic - #11259
Merged
chrisberkhout merged 2 commits intoSep 27, 2024
Merged
Conversation
chrisberkhout
added
Integration:carbon_black_cloud
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
���� Build Succeeded
|
|
efd6
approved these changes
Sep 26, 2024
Contributor
|
Package carbon_black_cloud - 2.5.4 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
When using the CEL input for the `alert_v7` data stream, data would load very slowly for two reason: - The page size defaulted to 20 results. - The `want_more` flag was incorrectly set to false. The response body has the fields `num_found` and `num_available`. The `num_found` field gives the total number of results matching the query. The `num_available` filed is equal to `min(num_found, 10000)`. Now `want_more` is true if `num_found` is less than the page size, so it will keep fetching more until less than a full page of results are found. The page size is increased from 20 (the default) to 100.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
When using the CEL input for the `alert_v7` data stream, data would load very slowly for two reason: - The page size defaulted to 20 results. - The `want_more` flag was incorrectly set to false. The response body has the fields `num_found` and `num_available`. The `num_found` field gives the total number of results matching the query. The `num_available` filed is equal to `min(num_found, 10000)`. Now `want_more` is true if `num_found` is less than the page size, so it will keep fetching more until less than a full page of results are found. The page size is increased from 20 (the default) to 100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Testing
I tested this manually.
When no results are found, the
num_foundfield is returned with the value0, so the pagination condition can assume it is always there.Checklist
changelog.ymlfile.