Skip to content

[O11y][HAProxy] Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations. - #11401

Merged
harnish-crest-data merged 5 commits into
elastic:mainfrom
chavdaharnish:harproxy-dashboard-update
Nov 20, 2024
Merged

[O11y][HAProxy] Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations.#11401
harnish-crest-data merged 5 commits into
elastic:mainfrom
chavdaharnish:harproxy-dashboard-update

Conversation

@harnish-crest-data

@harnish-crest-data harnish-crest-data commented Oct 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Bugfix

Proposed commit message

  • Update the description of the field haproxy.stat.connection.total that providing number of connections for frontend
  • There are OOTB dashboards visualizations for backend and server connections need to be removed. Updated all the dashboards with the proper filter and removed not relevant visualizations! Please refer img folder to compare the dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues
@harnish-crest-data harnish-crest-data self-assigned this Oct 11, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:haproxy HAProxy labels Oct 11, 2024
@harnish-crest-data
harnish-crest-data marked this pull request as ready for review October 23, 2024 07:23
@harnish-crest-data
harnish-crest-data requested a review from a team as a code owner October 23, 2024 07:23
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Oct 23, 2024
muthu-mps
muthu-mps reviewed Nov 19, 2024
View reviewed changes
Comment thread packages/haproxy/changelog.yml Outdated
Comment thread packages/haproxy/data_stream/stat/fields/fields.yml
metric_type: counter
description: |
Cumulative number of connections.
Cumulative number of frontend connections.

@muthu-mps muthu-mps Nov 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you gone through the documentation to confirm that this metric is for the frontend connections?

@harnish-crest-data harnish-crest-data Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please refer to this link.

79: conn_tot [.F..]: cumulative number of connections

L (Listeners), F (Frontends), B (Backends), and S (Servers).
@muthu-mps

muthu-mps commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Dashboard comments

  • Why do we have haproxy.stat.component_type : 1 the query filter? What is the differentiation factor? Are we capturing those in the document to make sure that the connection type value differentiate the frontend, backend etc...
  • Backend dashboard - Change the title Downtime seconds to Downtime (in seconds) or Downtime. Same applies for HTTP backend dashboard as well.
  • Frontend dashboard - Trafic volume overtime to Network trafic overtime.
  • HTTP Servers - Active Servers has multiple mentions. Hide the title if possible.
@harnish-crest-data @muthu-mps
Update packages/haproxy/changelog.yml
d4d9d36 
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@harnish-crest-data

harnish-crest-data commented Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Dashboard comments

  • Why do we have haproxy.stat.component_type : 1 the query filter? What is the differentiation factor? Are we capturing those in the document to make sure that the connection type value differentiate the frontend, backend etc...

Please checkout this field description. It says that Component type (0=frontend, 1=backend, 2=server, or 3=socket/listener). In some of the panel, the filter was already there. So we have moved it to the dashboard level to follow best practice.

  • Backend dashboard - Change the title Downtime seconds to Downtime (in seconds) or Downtime. Same applies for HTTP backend dashboard as well.

Sure, I will make this change.

  • Frontend dashboard - Trafic volume overtime to Network trafic overtime.

Sure, I will make this change.

  • HTTP Servers - Active Servers has multiple mentions. Hide the title if possible.

Sure, let me check if it looks good.
@harnish-crest-data

harnish-crest-data commented Nov 20, 2024

Copy link
Copy Markdown
Contributor Author

@muthu-mps Addressed review comments. Thank you!
@elasticmachine

elasticmachine commented Nov 20, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @harnish-elastic
@elastic-sonarqube

elastic-sonarqube Bot commented Nov 20, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
muthu-mps
muthu-mps approved these changes Nov 20, 2024
View reviewed changes

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@harnish-crest-data
harnish-crest-data merged commit 1158245 into elastic:main Nov 20, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Package haproxy - 1.14.1 containing this change is available at https://epr.elastic.co/package/haproxy/1.14.1/
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@harnish-crest-data @flexitrev
[O11y][HAProxy] Update misleading visualizations on haproxy.stat.conn…
4f54ef6 
…ection.total field and add new visualizations. (#11401)

* Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations
* filter out visualizations by component_type
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@harnish-crest-data
[O11y][HAProxy] Update misleading visualizations on haproxy.stat.conn…
9233cbc 
…ection.total field and add new visualizations. (elastic#11401)

* Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations
* filter out visualizations by component_type
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@harnish-crest-data @flexitrev
[O11y][HAProxy] Update misleading visualizations on haproxy.stat.conn…
e20edb7 
…ection.total field and add new visualizations. (#11401)

* Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations
* filter out visualizations by component_type
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@harnish-crest-data
[O11y][HAProxy] Update misleading visualizations on haproxy.stat.conn…
f134e52 
…ection.total field and add new visualizations. (elastic#11401)

* Update misleading visualizations on haproxy.stat.connection.total field and add new visualizations
* filter out visualizations by component_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:haproxy HAProxy Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

4 participants

@harnish-crest-data @muthu-mps @elasticmachine @andrewkroh