cisco_duo: include error response body when non-200 and fix next_offset handling - #11422
Merged
Conversation
efd6
added
Integration:cisco_duo
We cannot guarantee the shape of body.message and body.message_detail, so just include the known type resp.Body which should be short in the case of a non-200 response.
Contributor
🚀 Benchmarks reportTo see the full report comment with |
efd6
marked this pull request as ready for review
October 15, 2024 22:42
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
💚 Build Succeeded
History
cc @efd6 |
chrisberkhout
approved these changes
Oct 16, 2024
Contributor
|
Package cisco_duo - 2.0.2 containing this change is available at https://epr.elastic.co/search?package=cisco_duo |
5 tasks
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…et handling (elastic#11422) We cannot guarantee the shape of body.message and body.message_detail, so just include the known type resp.Body which should be short in the case of a non-200 response. The next_offset value is documented to be an array of two elements which must be used to construct the parameter by concatenation with a separating comma[1]. [1] https://duo.com/docs/adminapi#authentication-logs
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…et handling (elastic#11422) We cannot guarantee the shape of body.message and body.message_detail, so just include the known type resp.Body which should be short in the case of a non-200 response. The next_offset value is documented to be an array of two elements which must be used to construct the parameter by concatenation with a separating comma[1]. [1] https://duo.com/docs/adminapi#authentication-logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots