Skip to content

wiz: fix missing score handling and retain cloud_configuration_rule_description - #11489

Merged
efd6 merged 1 commit into
elastic:backport-wiz-1.8from
efd6:s5298-wiz-1.8
Oct 23, 2024
Merged

wiz: fix missing score handling and retain cloud_configuration_rule_description#11489
efd6 merged 1 commit into
elastic:backport-wiz-1.8from
efd6:s5298-wiz-1.8

Conversation

@efd6

@efd6 efd6 commented Oct 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 23, 2024
@efd6 efd6 self-assigned this Oct 23, 2024
@efd6 efd6 mentioned this pull request Oct 23, 2024
Merged
5 tasks
efd6
efd6 commented Oct 23, 2024
View reviewed changes
Comment thread packages/wiz/changelog.yml Outdated
Comment on lines 2 to 9

@efd6 efd6 Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately required to be a patch bump despite being an enhancement due to constraints that exist due to the use of preview marks in the 1.9 version of the integration published in main.

@kcreddy kcreddy Oct 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.
Comment thread packages/wiz/data_stream/issue/fields/fields.yml Outdated
Comment on lines 106 to 107

@efd6 efd6 Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be a match_only_text, but the other fields here, control_description and resolution_recommendation should also, so maintaining alignment and not breaking things by fixing those fields.
@elasticmachine

elasticmachine commented Oct 23, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Oct 23, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Oct 23, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💔 Build #17470 failed 77afc4cda6ccccd4043211f8db5ffc5126df7d58

cc @efd6
@efd6
efd6 marked this pull request as ready for review October 23, 2024 01:46
@efd6
efd6 requested a review from a team as a code owner October 23, 2024 01:46
@elasticmachine

elasticmachine commented Oct 23, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@kcreddy kcreddy mentioned this pull request Oct 23, 2024
Merged
5 tasks
@efd6
efd6 merged commit e696b38 into elastic:backport-wiz-1.8 Oct 23, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Package wiz - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=wiz
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@efd6
wiz: fix missing score handling and retain cloud_configuration_rule_d…
269d4ce 
…escription (#11489)
@efd6
efd6 deleted the s5298-wiz-1.8 branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @kcreddy