Skip to content

[ProxySG] Support 'bcreportermain_v1', 'bcreporterssl_v1', and 'ssl' formats - #11609

Merged
mjwolf merged 10 commits into
elastic:mainfrom
mjwolf:proxysg-more-formats
Nov 5, 2024
Merged

[ProxySG] Support 'bcreportermain_v1', 'bcreporterssl_v1', and 'ssl' formats#11609
mjwolf merged 10 commits into
elastic:mainfrom
mjwolf:proxysg-more-formats

Conversation

@mjwolf

@mjwolf mjwolf commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

In the ProxySG integration, add support for 'bcreportermain_v1', 'bcreporterssl_v1', and 'ssl' log formats. These formats are defined here: https://techdocs.broadcom.com/us/en/symantec-security-software/web-and-network-security/edge-swg/7-3/getting-started/page-help-administration/page-help-logging/log-formats/default-formats.html

As it's not possible to automatically detect what log format is being used, users of the integration will need to select the log format to be processed beforehand when setting up the input (this selector dropdown already exists, but previously only had one option).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
Add support for 'bcreportermain_v1' and 'ssl' log formats to the proxysg integration.
@mjwolf mjwolf added enhancement New feature or request Integration:proxysg Broadcom ProxySG labels Oct 31, 2024
@mjwolf
mjwolf requested a review from a team as a code owner October 31, 2024 18:57
@andrewkroh andrewkroh added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Oct 31, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@mjwolf mjwolf changed the title [ProxySG] Support 'bcreportermain_v1' and 'ssl' formats Nov 1, 2024
@mjwolf mjwolf changed the title [ProxySG] Support 'bcreportermain_v1', 'bcreportermain_v1', and 'ssl' formats Nov 1, 2024
@taylor-swanson

Copy link
Copy Markdown
Contributor

I'm still looking through this, but had one question (apologies in advance if I already asked this on the first proxysg review).

With regard to the access log format, is it expected that the stream of events we receive will only be in one format? Would we ever need to detect which format it is and handle accordingly?

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@mjwolf

mjwolf commented Nov 5, 2024

Copy link
Copy Markdown
Contributor Author

I'm still looking through this, but had one question (apologies in advance if I already asked this on the first proxysg review).

With regard to the access log format, is it expected that the stream of events we receive will only be in one format? Would we ever need to detect which format it is and handle accordingly?

Yes, the logs stream will only send the single configured format.

Since the log format is basically CSV, with no key names, I think it would be very difficult to automatically detect the format being used. A lot of them are similar, with a few differences that would be difficult to detect. I think any automatic detection would be unreliable, so instead the user will have to set up the log format in the input config ahead of time.

@mjwolf
mjwolf merged commit 90580c4 into elastic:main Nov 5, 2024
@mjwolf
mjwolf deleted the proxysg-more-formats branch November 5, 2024 21:14
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package proxysg - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=proxysg

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…formats (elastic#11609)

In the ProxySG integration, add support for 'bcreportermain_v1', 'bcreporterssl_v1', and 'ssl' log formats. These formats are defined here: https://techdocs.broadcom.com/us/en/symantec-security-software/web-and-network-security/edge-swg/7-3/getting-started/page-help-administration/page-help-logging/log-formats/default-formats.html

As it's not possible to automatically detect what log format is being used, users of the integration will need to select the log format to be processed beforehand when setting up the input (this selector dropdown already exists, but previously only had one option).
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…formats (elastic#11609)

In the ProxySG integration, add support for 'bcreportermain_v1', 'bcreporterssl_v1', and 'ssl' log formats. These formats are defined here: https://techdocs.broadcom.com/us/en/symantec-security-software/web-and-network-security/edge-swg/7-3/getting-started/page-help-administration/page-help-logging/log-formats/default-formats.html

As it's not possible to automatically detect what log format is being used, users of the integration will need to select the log format to be processed beforehand when setting up the input (this selector dropdown already exists, but previously only had one option).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:proxysg Broadcom ProxySG Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

4 participants