carbon_black_cloud: fix handling of source.address to be dependent on direction - #11622
Merged
Conversation
efd6
added
Integration:carbon_black_cloud
efd6
force-pushed
the
11616-carbon_black_cloud
branch
from
November 3, 2024 21:50
882e089 to
12be55e
Compare
Contributor
🚀 Benchmarks reportTo see the full report comment with |
efd6
marked this pull request as ready for review
November 3, 2024 23:13
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
… direction The netconn_domain is the DNS domain of the remote end of the connection, which means that it should be assigned to either source.domain or destination.domain depending on the value of netconn_inbound. The documentation indicates that it is a domain so we do not check whether it is an IP for assigning to the corresponding .ip field. The *.address field is left empty. ref:https://developer.carbonblack.com/reference/carbon-black-cloud/data-forwarder/schema/deprecated/endpoint.event-1.0.0/
efd6
force-pushed
the
11616-carbon_black_cloud
branch
from
November 5, 2024 03:07
12be55e to
f8c5d53
Compare
|
💚 Build Succeeded
History
cc @efd6 |
efd6
enabled auto-merge (squash)
November 5, 2024 08:05
Contributor
Author
|
Note AUTOMERGE ENABLED: IF YOU NEED CHANGES DO NOT APPROVE |
kcreddy
approved these changes
Nov 5, 2024
Comment on lines
183
to
+187
| ctx.source.ip = ctx.json?.local_ip; | ||
| ctx.source.port = ctx.json?.local_port; | ||
| ctx.destination.ip = ctx.json?.remote_ip; | ||
| ctx.destination.port = ctx.json?.remote_port; | ||
| ctx.destination.domain = ctx.json?.netconn_domain; |
Contributor
There was a problem hiding this comment.
Irrelevant to this PR, but instead of performing null-checks in every line, ctx.json?., the script processor could have global null-check
Contributor
|
Package carbon_black_cloud - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
… direction (elastic#11622) The netconn_domain is the DNS domain of the remote end of the connection, which means that it should be assigned to either source.domain or destination.domain depending on the value of netconn_inbound. The documentation indicates that it is a domain so we do not check whether it is an IP for assigning to the corresponding .ip field. The *.address field is left empty. ref:https://developer.carbonblack.com/reference/carbon-black-cloud/data-forwarder/schema/deprecated/endpoint.event-1.0.0/
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
… direction (elastic#11622) The netconn_domain is the DNS domain of the remote end of the connection, which means that it should be assigned to either source.domain or destination.domain depending on the value of netconn_inbound. The documentation indicates that it is a domain so we do not check whether it is an IP for assigning to the corresponding .ip field. The *.address field is left empty. ref:https://developer.carbonblack.com/reference/carbon-black-cloud/data-forwarder/schema/deprecated/endpoint.event-1.0.0/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The netconn_domain is the DNS domain of the remote end of the
connection, which means that it should be assigned to either
source.domain or destination.domain depending on the value of
netconn_inbound. The documentation indicates that it is a domain
so we do not check whether it is an IP for assigning to the
corresponding .ip field. The *.address field is left empty.
ref:https://developer.carbonblack.com/reference/carbon-black-cloud/data-forwarder/schema/deprecated/endpoint.event-1.0.0/
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots