Default to vulnerableAsset.id when vulnerableAsset.provider_unique_id is missing for resource.id - #11630
Merged
maxcold merged 4 commits intoNov 5, 2024
Merged
Default to vulnerableAsset.id when vulnerableAsset.provider_unique_id is missing for resource.id#11630maxcold merged 4 commits into
vulnerableAsset.id when vulnerableAsset.provider_unique_id is missing for resource.id#11630maxcold merged 4 commits into
Conversation
… is missing for resource.id
maxcold
added
enhancement
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
maxcold
commented
Nov 4, 2024
| tag: rename_vulnerableAsset_type | ||
| target_field: wiz.vulnerability.vulnerable_asset.type | ||
| ignore_missing: true | ||
| - remove: |
Contributor
Author
There was a problem hiding this comment.
moving these processors to the end, to where they were before new processors were added for CDR. In my case the wiz.vulnerability.vulnerable_asset.id was removed before I could use it, but it makes sense in general as well
Contributor
🚀 Benchmarks reportTo see the full report comment with |
kcreddy
reviewed
Nov 5, 2024
…peline/default.yml Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
💚 Build Succeeded
History
|
|
kcreddy
approved these changes
Nov 5, 2024
Contributor
|
Package wiz - 2.2.0 containing this change is available at https://epr.elastic.co/search?package=wiz |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…_id` is missing for `resource.id` (elastic#11630) * default to vulnerableAsset.id when vulnerableAsset.provider_unique_id is missing for resource.id * add more fields to be removed preserve_duplicate_custom_fields flag disabled * Update packages/wiz/data_stream/vulnerability/elasticsearch/ingest_pipeline/default.yml Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com> * delete remove event.original processor --------- Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…_id` is missing for `resource.id` (elastic#11630) * default to vulnerableAsset.id when vulnerableAsset.provider_unique_id is missing for resource.id * add more fields to be removed preserve_duplicate_custom_fields flag disabled * Update packages/wiz/data_stream/vulnerability/elasticsearch/ingest_pipeline/default.yml Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com> * delete remove event.original processor --------- Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
resource.idis the field used for wiz vulnerability latest transform as a unique key, if it's missing, multiple findings might be merged into one. In many cases (in 10k out of 300k results with dev API key) provider id for a resource is missing, but wiz generated id seems to be always present. Defaulting to this id when provider id is missingChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Test case added to the pipeline test
Related issues
Screenshots