Skip to content

tenable_sc: update tested versions note and user agent string - #11721

Merged
efd6 merged 0 commit into
elastic:mainfrom
efd6:11510-tenable_sc
Nov 15, 2024
Merged

tenable_sc: update tested versions note and user agent string#11721
efd6 merged 0 commit into
elastic:mainfrom
efd6:11510-tenable_sc

Conversation

@efd6

@efd6 efd6 commented Nov 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

It appears that the API has become more strict with the user-agent
string format that is acceptable. Using the format that was previously
in place, including the filebeat component of the string, results in a
403 unauthorized, so conform exactly to the format described in the
developer documentation.

ref:https://developer.tenable.com/docs/user-agent-header

Note

Tested locally ✅

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

  1. Install the new version of the integration (git fetch git@github.com:efd6/integrations.git 11510-tenable_sc && git checkout FETCH_HEAD && cd packages/tenable_sc && elastic-package build)
  2. Run an elastic-package instance.
  3. Go through the kibana integration install process and add a policy with your credentials.
  4. Check for document ingest.

Related issues

Screenshots
@efd6 efd6 added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:tenable_sc Tenable Security Center Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 12, 2024
@efd6 efd6 self-assigned this Nov 12, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Nov 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package tenable_sc 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 2518.89 1926.78 -592.11 (-23.51%) 💔
plugin 2557.54 2012.07 -545.47 (-21.33%) 💔

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Nov 13, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Nov 13, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #18256 succeeded e6e83b800f4eeeefd5eb9f77d9fa9b0c2ac80e71

cc @efd6
@efd6 efd6 changed the title tenable_sc: update tested versions note Nov 13, 2024
@efd6
efd6 marked this pull request as ready for review November 13, 2024 23:45
@efd6
efd6 requested a review from a team as a code owner November 13, 2024 23:45
@elasticmachine

elasticmachine commented Nov 13, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
kcreddy
kcreddy reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/tenable_sc/data_stream/asset/agent/stream/httpjson.yml.hbs Outdated

@kcreddy kcreddy Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build/1.24.0 should this be kept in sync with latest changelog entry every time?

@efd6 efd6 Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check with a different version, but it does not work with the other text that is there now.

@kcreddy kcreddy Nov 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've checked the doc. Looks like the version identifier is only for tracking the versions. I guess it may not be required to keep it in sync every time.

VERSION—The version identifier. This attribute allows the ability to track the various versions of your integrations being used.
Comment thread packages/tenable_sc/_dev/build/docs/README.md Outdated
Comment thread packages/tenable_sc/changelog.yml Outdated
kcreddy
kcreddy approved these changes Nov 15, 2024
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 7d8db5e into elastic:main Nov 15, 2024
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Package tenable_sc - 1.24.0 containing this change is available at https://epr.elastic.co/package/tenable_sc/1.24.0/
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
tenable_sc: update tested versions note and user agent string (elasti…
88658e4 
…c#11721)

It appears that the API has become more strict with the user-agent
string format that is acceptable. Using the format that was previously
in place, including the filebeat component of the string, results in a
403 unauthorized, so conform exactly to the format described in the
developer documentation.

ref:https://developer.tenable.com/docs/user-agent-header
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
tenable_sc: update tested versions note and user agent string (elasti…
0e9b8bb 
…c#11721)

It appears that the API has become more strict with the user-agent
string format that is acceptable. Using the format that was previously
in place, including the filebeat component of the string, results in a
403 unauthorized, so conform exactly to the format described in the
developer documentation.

ref:https://developer.tenable.com/docs/user-agent-header
@efd6
efd6 deleted the 11510-tenable_sc branch February 5, 2025 22:01
@github-actions github-actions Bot mentioned this pull request Jun 1, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:tenable_sc Tenable Security Center Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @kcreddy