Skip to content

cisco_duo: fix the handling of details field for Activity logs - #11744

Merged
chemamartinez merged 0 commit into
elastic:mainfrom
chemamartinez:cisco_duo-fix-details-field
Nov 18, 2024
Merged

cisco_duo: fix the handling of details field for Activity logs#11744
chemamartinez merged 0 commit into
elastic:mainfrom
chemamartinez:cisco_duo-fix-details-field

Conversation

@chemamartinez

Copy link
Copy Markdown
Contributor

Proposed commit message

For the Activity data stream, logs that include the following fields actor.details, old_target.details and target.details are not being indexed due to this error:

Failed to parse object: expecting token of type [START_OBJECT] but found [VALUE_STRING]

These fields contain valid JSON objects so they are defined as flattened, however, the API returns these fields as an escaped string.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@chemamartinez chemamartinez added Integration:cisco_duo Cisco Duo bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 14, 2024
@chemamartinez chemamartinez self-assigned this Nov 14, 2024
@chemamartinez
chemamartinez marked this pull request as ready for review November 14, 2024 15:45
@chemamartinez
chemamartinez requested a review from a team as a code owner November 14, 2024 15:45
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment thread packages/cisco_duo/data_stream/activity/_dev/test/pipeline/test-activity.log Outdated
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #18335 succeeded ff910cb9fd444b6ede1414021d18fb3d9e273e0d

cc @chemamartinez

@chemamartinez
chemamartinez merged commit 6323612 into elastic:main Nov 18, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_duo - 2.2.4 containing this change is available at https://epr.elastic.co/package/cisco_duo/2.2.4/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@chemamartinez
chemamartinez deleted the cisco_duo-fix-details-field branch February 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_duo Cisco Duo Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants