Skip to content

[cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1 - #11800

Merged
aleksmaus merged 0 commit into
elastic:mainfrom
aleksmaus:revert/cisco_ise_mapping_change
Nov 22, 2024
Merged

[cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1#11800
aleksmaus merged 0 commit into
elastic:mainfrom
aleksmaus:revert/cisco_ise_mapping_change

Conversation

@aleksmaus

Copy link
Copy Markdown
Contributor

Proposed commit message

[cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1
https://github.com/elastic/integrations/pull/11619/files#diff-ce8c42e24fb4e94c7fb135eed466345a68c36cb91a247069fb9ea88312f97bbbL228

The mapping change in 1.24.1 causes the error, when the user tries to use to update to this version of integration

mapper_exception Root causes: mapper_exception the (enabled) parameter can't be upgraded for the object mapping [cisco_ise.log.cisco_av_pair].

Similar issue with Okta integration that happened earlier was mentioned here
https://support.elastic.dev/knowledge/view/1a2f83e7
and the kibana ticket
elastic/kibana#193044

The discussed and accepted solution is:

  1. Revert the mapping change with this PR (next patch release)
  2. Follow up with PR with the breaking mapping change with the next minor release of the package with constraint on 8.17 if the fix on Kibana side is added with 8.17.

In addition, added a filtering code that ensures that only known mapped fields for cisco_av_pair namely:

coa-push
cts-device-capability
cts-environment-data
cts-environment-version
cts-pac-opaque

are indexed. All the other fields are discarded. The tests were failing otherwise for the new logs with the new key/values.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@aleksmaus aleksmaus added Integration:cisco_ise Cisco ISE bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Nov 21, 2024
@aleksmaus aleksmaus self-assigned this Nov 21, 2024
@aleksmaus
aleksmaus requested a review from a team as a code owner November 21, 2024 01:30
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @aleksmaus

@aleksmaus
aleksmaus merged commit f1bc15c into elastic:main Nov 22, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.24.2 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.24.2/

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
…ed with 1.24.1 (#11800)

* [cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1

* Update changelog with PR number
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…ed with 1.24.1 (elastic#11800)

* [cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1

* Update changelog with PR number
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…ed with 1.24.1 (#11800)

* [cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1

* Update changelog with PR number
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…ed with 1.24.1 (elastic#11800)

* [cisco_ise] Revert mapping change for cisco_av_pair that was introduced with 1.24.1

* Update changelog with PR number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_ise Cisco ISE Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants