Skip to content

[checkpoint] Align hostname grok pattern with syslog RFC - #11947

Merged
taylor-swanson merged 0 commit into
elastic:mainfrom
taylor-swanson:fix/checkpoint-hostname-field
Dec 2, 2024
Merged

[checkpoint] Align hostname grok pattern with syslog RFC#11947
taylor-swanson merged 0 commit into
elastic:mainfrom
taylor-swanson:fix/checkpoint-hostname-field

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Change hostname grok pattern to use SYSLOG5424PRINTASCII instead of IPORHOST to align with RFC 5424.
  • Add test case

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/checkpoint
elastic-package test
@taylor-swanson taylor-swanson added Integration:checkpoint Check Point bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 2, 2024
@taylor-swanson taylor-swanson self-assigned this Dec 2, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson
taylor-swanson marked this pull request as ready for review December 2, 2024 14:22
@taylor-swanson
taylor-swanson requested a review from a team as a code owner December 2, 2024 14:22
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson
taylor-swanson merged commit 0980e01 into elastic:main Dec 2, 2024
@taylor-swanson
taylor-swanson deleted the fix/checkpoint-hostname-field branch December 2, 2024 15:28
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package checkpoint - 1.34.3 containing this change is available at https://epr.elastic.co/package/checkpoint/1.34.3/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
- Change hostname grok pattern to use SYSLOG5424PRINTASCII instead
of IPORHOST to align with RFC 5424.
- Add test case
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
- Change hostname grok pattern to use SYSLOG5424PRINTASCII instead
of IPORHOST to align with RFC 5424.
- Add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:checkpoint Check Point Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants