Skip to content

packages/salesforce: Fix processor syntax issue when adding new ones - #12097

Merged
shmsr merged 0 commit into
elastic:mainfrom
shmsr:salesforce-processor-syntax
Dec 15, 2024
Merged

packages/salesforce: Fix processor syntax issue when adding new ones#12097
shmsr merged 0 commit into
elastic:mainfrom
shmsr:salesforce-processor-syntax

Conversation

@shmsr

@shmsr shmsr commented Dec 13, 2024

Copy link
Copy Markdown
Member

Proposed commit message

Remove indentation from processors to avoid syntax error when adding new processors. This changed is required so that when processors are added from the UI they are at the same level (indentation) as the already added processors i.e., making it syntactically correct when formatted. Only apex is affected, for other datasets, it is in expected form.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Tested by adding - add_fields: { fields: { my_id: "12345" } } from the UI in processors.

@shmsr
shmsr requested a review from a team as a code owner December 13, 2024 11:14
@shmsr shmsr self-assigned this Dec 13, 2024
@shmsr
shmsr requested a review from kush-elastic December 13, 2024 11:14
@shmsr

shmsr commented Dec 13, 2024

Copy link
Copy Markdown
Member Author

Confirmed from the Agent Policy that processor when added from UI works:

        processors:
          - add_fields:
              target: salesforce
              fields:
                instance_url: 'https://instance-url.salesforce.com'
          - add_fields:
              fields:
                my_id: '12345'
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @shmsr

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 13, 2024
@shmsr
shmsr merged commit 53e2c5a into elastic:main Dec 15, 2024
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package salesforce - 1.0.1 containing this change is available at https://epr.elastic.co/package/salesforce/1.0.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@shmsr
shmsr deleted the salesforce-processor-syntax branch February 6, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

4 participants