[vsphere] Add support for Shared Secrets /SSL Thumbprint Logins and add more granular filtering for file pipeline - #12146
Merged
muthu-mps merged 0 commit intoJan 13, 2025
Conversation
andrewkroh
added
enhancement
Contributor
🚀 Benchmarks reportTo see the full report comment with |
SimonKoetting
changed the title
muthu-mps
reviewed
Jan 13, 2025
💚 Build Succeeded
History
|
|
Contributor
|
Package vsphere - 1.17.0 containing this change is available at https://epr.elastic.co/package/vsphere/1.17.0/ |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…dd more granular filtering for file pipeline (elastic#12146) * Add support for shared secret login messages
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…dd more granular filtering for file pipeline (elastic#12146) * Add support for shared secret login messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vsphere also supports shared secrets & SSL thumbprints to login. When the login happens with a shared secret or ssl thumbprint, the log message looks slighty diffrent which currently caused the dissect to fail.
Also the file pipeline just filtered if the message contains "Upload", this causes some errors when there are logs containing the Upload string like in
/LicensingStats/LicenseServiceProxy::UploadLicenseFilewhich is a complete diffrent log.