Skip to content

Update dga package to spec 3.0.4 - #12153

Merged
jsoriano merged 0 commit into
elastic:mainfrom
jsoriano:update-dga-spec-3.x
Dec 19, 2024
Merged

Update dga package to spec 3.0.4#12153
jsoriano merged 0 commit into
elastic:mainfrom
jsoriano:update-dga-spec-3.x

Conversation

@jsoriano

Copy link
Copy Markdown
Contributor

Proposed commit message

Update DGA package to spec 3.0.4.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@jsoriano jsoriano self-assigned this Dec 18, 2024
@jsoriano
jsoriano requested review from a team as code owners December 18, 2024 17:03
@jsoriano
jsoriano marked this pull request as draft December 18, 2024 17:03
@andrewkroh andrewkroh added the Integration:dga Domain Generation Algorithm Detection label Dec 18, 2024
@jsoriano

Copy link
Copy Markdown
Contributor Author

/test

@jsoriano
jsoriano force-pushed the update-dga-spec-3.x branch from 3100e60 to 14e89ff Compare December 18, 2024 17:58
@andrewkroh andrewkroh added the enhancement New feature or request label Dec 18, 2024
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #19671 succeeded 3100e600f32fb7480d2ff4f77d31c8059efe652e
  • 💔 Build #19668 failed 3100e600f32fb7480d2ff4f77d31c8059efe652e

cc @jsoriano

@sodhikirti07 sodhikirti07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

Comment thread packages/dga/manifest.yml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 3.3.1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am being cautious as this package is intended to be used for versions of kibana since 8.9, see #12156 (comment).

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ML

@jsoriano
jsoriano marked this pull request as ready for review December 19, 2024 13:46
@jsoriano
jsoriano merged commit c1e4ce7 into elastic:main Dec 19, 2024
@jsoriano
jsoriano deleted the update-dga-spec-3.x branch December 19, 2024 13:46
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package dga - 2.1.0 containing this change is available at https://epr.elastic.co/package/dga/2.1.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:dga Domain Generation Algorithm Detection

5 participants