Skip to content

[O11y][MSSQL] Add mssql.query field to transaction_logs data stream for debug purposes - #12216

Merged
harnish-crest-data merged 0 commit into
elastic:mainfrom
chavdaharnish:mssql-add-sql-query
Jan 17, 2025
Merged

[O11y][MSSQL] Add mssql.query field to transaction_logs data stream for debug purposes#12216
harnish-crest-data merged 0 commit into
elastic:mainfrom
chavdaharnish:mssql-add-sql-query

Conversation

@harnish-crest-data

@harnish-crest-data harnish-crest-data commented Jan 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

Proposed commit message

  • Add preserve_sql_queries flag to transaction_log data stream that can be used as preserve sql.query field, if it's enabled.
  • Generate system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

  • Debug Flag

debug-flag

  • Debug Flag Enabled Event

with-debug-flag-event

  • Debug Flag Disabled Event

without-debug-flag-event
@harnish-crest-data harnish-crest-data added enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jan 1, 2025
@harnish-crest-data harnish-crest-data self-assigned this Jan 1, 2025
@harnish-crest-data
harnish-crest-data marked this pull request as ready for review January 1, 2025 06:46
@harnish-crest-data
harnish-crest-data requested a review from a team as a code owner January 1, 2025 06:46
@harnish-crest-data harnish-crest-data mentioned this pull request Jan 1, 2025
Merged
5 tasks
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
shmsr
shmsr reviewed Jan 7, 2025
View reviewed changes
Comment thread packages/microsoft_sqlserver/data_stream/transaction_log/fields/fields.yml Outdated
shmsr
shmsr requested changes Jan 7, 2025
View reviewed changes
Comment thread packages/microsoft_sqlserver/data_stream/transaction_log/manifest.yml Outdated
shmsr
shmsr reviewed Jan 7, 2025
View reviewed changes
Comment thread packages/microsoft_sqlserver/changelog.yml Outdated
@shmsr shmsr mentioned this pull request Jan 9, 2025
Merged
6 tasks
@mergify mergify Bot mentioned this pull request Jan 10, 2025
Merged
6 tasks
@shmsr

shmsr commented Jan 16, 2025

Copy link
Copy Markdown
Member

Make this PR consistent with #12212
@harnish-crest-data

harnish-crest-data commented Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

Make this PR consistent with #12212

Updated, thanks!
@shmsr

shmsr commented Jan 17, 2025

Copy link
Copy Markdown
Member

Can we make it 2.10.1 instead of 2.11? Rest looks good!
@elastic-sonarqube

elastic-sonarqube Bot commented Jan 17, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Jan 17, 2025

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #20592 succeeded 93198874e86f62e0f28b80fa5a04a33c5a6a76bf
  • 💚 Build #20510 succeeded 6ba0b109e25cc7dab14ed5eba74880c1ffa18725
  • 💚 Build #20468 succeeded 7dd6387b2ce21345fa6582533ad6db85f19166d1
  • 💚 Build #20087 succeeded 2c6181c0342244d8d283cef67a0db624bef5d721
  • 💔 Build #20080 failed 0d9c60f1d7a35285666aa968f0ac9fe955192a80
  • 💚 Build #19943 succeeded ef8fbad7bd3bbf40fa35bc4e9ff13241a35a0410

cc @harnish-elastic
@harnish-crest-data
harnish-crest-data merged commit 038024e into elastic:main Jan 17, 2025
@harnish-crest-data harnish-crest-data mentioned this pull request Jan 17, 2025
Closed
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Package microsoft_sqlserver - 2.10.1 containing this change is available at https://epr.elastic.co/package/microsoft_sqlserver/2.10.1/
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@harnish-crest-data
[O11y][MSSQL] Add mssql.query field to transaction_logs data stream…
ac6d167 
… for debug purposes (elastic#12216)

* Add mssql field to `transaction_logs` data stream for debug purposes.

* add PR link in changelog.yml

* address review comments

* elastic-package check

* address review comments

* update changelog
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@harnish-crest-data
[O11y][MSSQL] Add mssql.query field to transaction_logs data stream…
102af6a 
… for debug purposes (elastic#12216)

* Add mssql field to `transaction_logs` data stream for debug purposes.

* add PR link in changelog.yml

* address review comments

* elastic-package check

* address review comments

* update changelog
@harnish-crest-data
harnish-crest-data deleted the mssql-add-sql-query branch February 7, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

3 participants

@harnish-crest-data @shmsr @elasticmachine