Skip to content

[trend_micro_vision_one] - Added configurable page size option for the detection and audit data streams - #12282

Merged
ShourieG merged 0 commit into
elastic:mainfrom
ShourieG:bugfix/vision_one
Jan 9, 2025
Merged

[trend_micro_vision_one] - Added configurable page size option for the detection and audit data streams#12282
ShourieG merged 0 commit into
elastic:mainfrom
ShourieG:bugfix/vision_one

Conversation

@ShourieG

@ShourieG ShourieG commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

Proposed commit message

Made page size for audit and detection data streams configurable and set more modest default page size values to avoid
buffer overflow/ heap errors.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG added enhancement New feature or request integration Label used for meta issues tracking each integration Integration:trend_micro_vision_one TrendAI Vision One Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 9, 2025
@ShourieG ShourieG self-assigned this Jan 9, 2025
@ShourieG
ShourieG requested a review from a team as a code owner January 9, 2025 05:40
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package trend_micro_vision_one 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 1879.7 1434.72 -444.98 (-23.67%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @ShourieG

@ShourieG
ShourieG requested a review from kcreddy January 9, 2025 07:45
@ShourieG
ShourieG merged commit 6bdd475 into elastic:main Jan 9, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package trend_micro_vision_one - 1.24.0 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/1.24.0/

@ShourieG
ShourieG deleted the bugfix/vision_one branch January 9, 2025 10:16
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:trend_micro_vision_one TrendAI Vision One integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants