Skip to content

[Search Connectors] remove links to all connectors in README - #12345

Merged
meghanmurphy1 merged 0 commit into
elastic:mainfrom
meghanmurphy1:remove-connector-refrences
Jan 16, 2025
Merged

[Search Connectors] remove links to all connectors in README#12345
meghanmurphy1 merged 0 commit into
elastic:mainfrom
meghanmurphy1:remove-connector-refrences

Conversation

@meghanmurphy1

@meghanmurphy1 meghanmurphy1 commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

elastic-package build and manually upload to Kibana
For E2E cloud testing with agentless follow these steps https://docs.google.com/document/d/1w6aHL0IQlI4RvNZj9jaAA8drdwwMMT2NuUAOQBtXyAk/edit?tab=t.0#heading=h.7o64p4gmw1so

Related issues

Screenshots

Screenshot 2025-01-14 at 11 26 18 AM
@andrewkroh andrewkroh added enhancement New feature or request Integration:elastic_connectors Elastic Connectors labels Jan 14, 2025
@meghanmurphy1 meghanmurphy1 self-assigned this Jan 14, 2025
@meghanmurphy1
meghanmurphy1 marked this pull request as ready for review January 14, 2025 16:38
@meghanmurphy1
meghanmurphy1 requested a review from a team as a code owner January 14, 2025 16:38
seanstory
seanstory approved these changes Jan 14, 2025
View reviewed changes

@seanstory seanstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit
Comment thread packages/elastic_connectors/docs/README.md Outdated
@andrewkroh andrewkroh added the Team:Search-Extract and Transform Search - Extract and Transform team [elastic/search-extract-and-transform] label Jan 14, 2025
danajuratoni
danajuratoni reviewed Jan 15, 2025
View reviewed changes
Comment thread packages/elastic_connectors/docs/README.md Outdated

@danajuratoni danajuratoni Jan 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either directly link to elastic managed connectors
https://www.elastic.co/guide/en/elasticsearch/reference/current/es-native-connectors.html
or slightly rephrase it to reference Elastic connectors
e.g. Read our documentation to learn more about the available [Elastic Connectors]

@meghanmurphy1 meghanmurphy1 Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!
@danajuratoni

danajuratoni commented Jan 15, 2025

Copy link
Copy Markdown

Left one small comment. Great idea to simplify this!
@elasticmachine

elasticmachine commented Jan 16, 2025

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #20457 succeeded 195330b0971c6b9bef290db53f99eb210f1fd65d
  • 💚 Build #20404 succeeded eb43d7f792b7eda8ce9de7c9804a71547082b9bd
  • 💚 Build #20399 succeeded 36f3530cd2a8f9ca70b46c275ea81548dd429277

cc @meghanmurphy1
@elastic-sonarqube

elastic-sonarqube Bot commented Jan 16, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@meghanmurphy1
meghanmurphy1 merged commit c8437f7 into elastic:main Jan 16, 2025
@meghanmurphy1
meghanmurphy1 deleted the remove-connector-refrences branch January 16, 2025 15:16
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

Package elastic_connectors - 1.0.0 containing this change is available at https://epr.elastic.co/package/elastic_connectors/1.0.0/
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@meghanmurphy1
[Search Connectors] remove links to all connectors in README (elastic…
30aae0f 
…#12345)

* update version to 1.0.0 and remove links to all connectors in README

* add changelog link

* update manifest.yml

* capitalize Elastic

* refer directly to Elastic-managed connectors

* refrence Connector documentation
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@meghanmurphy1
[Search Connectors] remove links to all connectors in README (elastic…
a96cb69 
…#12345)

* update version to 1.0.0 and remove links to all connectors in README

* add changelog link

* update manifest.yml

* capitalize Elastic

* refer directly to Elastic-managed connectors

* refrence Connector documentation
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Package crowdstrike - 1.62.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/1.62.0/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Package sentinel_one - 1.32.0 containing this change is available at https://epr.elastic.co/package/sentinel_one/1.32.0/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:elastic_connectors Elastic Connectors Team:Search-Extract and Transform Search - Extract and Transform team [elastic/search-extract-and-transform]

5 participants

@meghanmurphy1 @danajuratoni @elasticmachine @seanstory @andrewkroh