Skip to content

[integrations][trend_micro_vision_one] - Fixed inconsistent time interval issue leading to data loss in the detections data stream - #12425

Merged
ShourieG merged 0 commit into
elastic:mainfrom
ShourieG:bugfix/vision_one
Jan 24, 2025
Merged

[integrations][trend_micro_vision_one] - Fixed inconsistent time interval issue leading to data loss in the detections data stream#12425
ShourieG merged 0 commit into
elastic:mainfrom
ShourieG:bugfix/vision_one

Conversation

@ShourieG

@ShourieG ShourieG commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

Fixed inconsistent time interval issue leading to data loss in the detections data stream. The cursor time has been updated to the "eventTimeDT" field of the 1st event for every response cycle leading to a smoother time interval without gaps. Events returned are always sorted in decreasing order of time, thus the 1st event of every response will always contain the latest event for that response.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG
ShourieG requested a review from a team as a code owner January 22, 2025 10:52
@ShourieG ShourieG self-assigned this Jan 22, 2025
@ShourieG ShourieG added Integration:trend_micro_vision_one TrendAI Vision One bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 22, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @ShourieG

@ShourieG

Copy link
Copy Markdown
Contributor Author

@chrisberkhout, could you take a look at this updated logic. I think with the recent info provided, this small change should be enough for the interval gap issue.

@chrisberkhout chrisberkhout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Very nice commit message!

Maybe as a separate change, but it would be good the same thing for the alert and audit as well. They're less affected because they only a last_update_at cursor value for the beginning of a new pagination sequence, but the fix should be as easy there (although with different field names).

@ShourieG
ShourieG merged commit c961493 into elastic:main Jan 24, 2025
@ShourieG
ShourieG deleted the bugfix/vision_one branch January 24, 2025 04:29
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package trend_micro_vision_one - 1.24.1 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/1.24.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…rval issue leading to data loss in the detections data stream (elastic#12425)

Fixed inconsistent time interval issue leading to data loss in the detections data stream. The cursor time has been updated to the "eventTimeDT" field of the 1st event for every response cycle leading to a smoother time interval without gaps. Events returned are always sorted in decreasing order of time, thus the 1st event of every response will always contain the latest event for that response.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…rval issue leading to data loss in the detections data stream (elastic#12425)

Fixed inconsistent time interval issue leading to data loss in the detections data stream. The cursor time has been updated to the "eventTimeDT" field of the 1st event for every response cycle leading to a smoother time interval without gaps. Events returned are always sorted in decreasing order of time, thus the 1st event of every response will always contain the latest event for that response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:trend_micro_vision_one TrendAI Vision One Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants