Skip to content

sentinel_one: handle comma-separated IP lists - #12702

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:12550-sentinel_one
Feb 11, 2025
Merged

sentinel_one: handle comma-separated IP lists#12702
efd6 merged 2 commits into
elastic:mainfrom
efd6:12550-sentinel_one

Conversation

@efd6

@efd6 efd6 commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 10, 2025
@efd6 efd6 self-assigned this Feb 10, 2025
@efd6
efd6 force-pushed the 12550-sentinel_one branch from b1b078c to a16b535 Compare February 10, 2025 23:44
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
efd6 marked this pull request as ready for review February 11, 2025 00:55
@efd6
efd6 requested a review from a team as a code owner February 11, 2025 00:55
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chemamartinez chemamartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix first the field description.

description: Status.
- name: report_id
type: keyword
description: Status.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description of this field.

@efd6
efd6 enabled auto-merge (squash) February 11, 2025 20:19
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @efd6

@efd6
efd6 merged commit cccd5a3 into elastic:main Feb 11, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package sentinel_one - 1.28.0 containing this change is available at https://epr.elastic.co/package/sentinel_one/1.28.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants