Skip to content

Updated description on ssl node in data_stream to be uniform and include links to online documentation for integrations owned by sec-deployment-and-devices - #12753

Merged
StacieClark-Elastic merged 1 commit into
elastic:mainfrom
StacieClark-Elastic:bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701
Feb 13, 2025
Merged

Updated description on ssl node in data_stream to be uniform and include links to online documentation for integrations owned by sec-deployment-and-devices#12753
StacieClark-Elastic merged 1 commit into
elastic:mainfrom
StacieClark-Elastic:bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701

Conversation

@StacieClark-Elastic

@StacieClark-Elastic StacieClark-Elastic commented Feb 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updated ssl node descriptions in data_streams owned by sec-deployment-and-devices. This commit updates or adds descriptions to the ssl node to be uniform and to include links to online documentation. One is co-owned by obs-infraobs-integrations.

Proposed commit message

Updated ssl node descriptions in data_streams owned by sec-deployment-and-devices. This commit updates or adds descriptions to the ssl node to be uniform and to include links to online documentation. One is co-owned by obs-infraobs-integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Originally, we updated the descriptions on all the files in integration. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by sec-deployment-and-devices,
One is owned by bs-infraobs-integrations. As such the only verification would be to check that was what updates is uniform. Note that the metrics type datastream points to a metricbeat documentation while logs point to filebeat.

git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml

Related issues
@StacieClark-Elastic
bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701
41e17d9 
Updated descriptions on ssl node in data_stream manifest.yml files owned by sec-deployment-and-devices
@StacieClark-Elastic
StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701 branch from 6a7bad9 to 41e17d9 Compare February 12, 2025 18:38
@StacieClark-Elastic
StacieClark-Elastic marked this pull request as ready for review February 12, 2025 18:40
@StacieClark-Elastic
StacieClark-Elastic requested review from a team as code owners February 12, 2025 18:40
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Feb 12, 2025

Copy link
Copy Markdown

💚 Build Succeeded
@elastic-sonarqube

elastic-sonarqube Bot commented Feb 12, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@StacieClark-Elastic StacieClark-Elastic added Integration:squid Squid Proxy Integration:sophos Sophos Integration:cef Common Event Format (CEF) Integration:panw Palo Alto Next-Gen Firewall Integration:imperva Imperva Integration:juniper_srx Juniper SRX Integration:checkpoint Check Point Integration:hashicorp_vault Hashicorp Vault Integration:cisco_nexus Cisco Nexus Integration:cisco_ios Cisco IOS Integration:cisco_ftd Cisco FTD Integration:cisco_asa Cisco ASA Integration:pfsense pfSense (Community supported) Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:citrix_waf Citrix Web App Firewall Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:cisco_aironet Cisco Aironet (Community supported) bugfix Pull request that fixes a bug issue Integration:tcp Custom TCP Logs Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Integration:citrix_adc Citrix ADC labels Feb 12, 2025
mjwolf
mjwolf approved these changes Feb 12, 2025
View reviewed changes

@mjwolf mjwolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@StacieClark-Elastic StacieClark-Elastic self-assigned this Feb 13, 2025
@StacieClark-Elastic
StacieClark-Elastic merged commit d13ae47 into elastic:main Feb 13, 2025
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cef - 2.20.1 containing this change is available at https://epr.elastic.co/package/cef/2.20.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package checkpoint - 1.37.1 containing this change is available at https://epr.elastic.co/package/checkpoint/1.37.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_aironet - 1.15.1 containing this change is available at https://epr.elastic.co/package/cisco_aironet/1.15.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_asa - 2.42.1 containing this change is available at https://epr.elastic.co/package/cisco_asa/2.42.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_ftd - 3.6.1 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.6.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_ios - 1.29.1 containing this change is available at https://epr.elastic.co/package/cisco_ios/1.29.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_nexus - 1.3.1 containing this change is available at https://epr.elastic.co/package/cisco_nexus/1.3.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package cisco_secure_email_gateway - 1.25.1 containing this change is available at https://epr.elastic.co/package/cisco_secure_email_gateway/1.25.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package citrix_adc - 1.13.1 containing this change is available at https://epr.elastic.co/package/citrix_adc/1.13.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package citrix_waf - 1.17.1 containing this change is available at https://epr.elastic.co/package/citrix_waf/1.17.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package fortinet_fortigate - 1.29.2 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.29.2/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package fortinet_fortimail - 2.14.1 containing this change is available at https://epr.elastic.co/package/fortinet_fortimail/2.14.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package fortinet_fortimanager - 2.14.1 containing this change is available at https://epr.elastic.co/package/fortinet_fortimanager/2.14.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package fortinet_fortiproxy - 1.1.1 containing this change is available at https://epr.elastic.co/package/fortinet_fortiproxy/1.1.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package hashicorp_vault - 1.26.1 containing this change is available at https://epr.elastic.co/package/hashicorp_vault/1.26.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package imperva - 1.4.1 containing this change is available at https://epr.elastic.co/package/imperva/1.4.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package juniper_srx - 1.22.1 containing this change is available at https://epr.elastic.co/package/juniper_srx/1.22.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package panw - 5.1.1 containing this change is available at https://epr.elastic.co/package/panw/5.1.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package pfsense - 1.21.1 containing this change is available at https://epr.elastic.co/package/pfsense/1.21.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package proxysg - 0.5.1 containing this change is available at https://epr.elastic.co/package/proxysg/0.5.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package qnap_nas - 1.21.1 containing this change is available at https://epr.elastic.co/package/qnap_nas/1.21.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package sophos - 3.12.1 containing this change is available at https://epr.elastic.co/package/sophos/3.12.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package squid - 1.1.1 containing this change is available at https://epr.elastic.co/package/squid/1.1.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package stormshield - 1.1.1 containing this change is available at https://epr.elastic.co/package/stormshield/1.1.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package syslog_router - 0.1.2 containing this change is available at https://epr.elastic.co/package/syslog_router/0.1.2/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Package tcp - 1.20.1 containing this change is available at https://epr.elastic.co/package/tcp/1.20.1/
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@StacieClark-Elastic @flexitrev
bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701 (
35af18e 
#12753)

Updated descriptions on ssl node in data_stream manifest.yml files owned by sec-deployment-and-devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cef Common Event Format (CEF) Integration:checkpoint Check Point Integration:cisco_aironet Cisco Aironet (Community supported) Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_nexus Cisco Nexus Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:citrix_adc Citrix ADC Integration:citrix_waf Citrix Web App Firewall Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:fortinet_fortimail Fortinet FortiMail Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:fortinet_fortiproxy Fortinet FortiProxy Integration:hashicorp_vault Hashicorp Vault Integration:imperva Imperva Integration:juniper_srx Juniper SRX Integration:panw Palo Alto Next-Gen Firewall Integration:pfsense pfSense (Community supported) Integration:proxysg Broadcom ProxySG Integration:qnap_nas QNAP NAS (Community supported) Integration:sophos Sophos Integration:squid Squid Proxy Integration:stormshield StormShield SNS Integration:syslog_router Syslog Router Integration:tcp Custom TCP Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants

@StacieClark-Elastic @elasticmachine @mjwolf