digital_guardian: fix mapping of dg_alert.alert_wb field and add export profile guid - #12818
Merged
Conversation
efd6
added
bugfix
efd6
force-pushed
the
12441-digital_guardian
branch
from
February 18, 2025 03:33
7807ffa to
3358e4b
Compare
efd6
commented
Feb 18, 2025
Contributor
Author
There was a problem hiding this comment.
The alternative here is to keep this as an integer and map to 0/1.
efd6
force-pushed
the
12441-digital_guardian
branch
from
February 18, 2025 03:50
3358e4b to
de4ba06
Compare
Contributor
🚀 Benchmarks reportTo see the full report comment with |
efd6
marked this pull request as ready for review
February 18, 2025 04:21
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
reviewed
Feb 19, 2025
Comment on lines
+16
to
+24
| - name: dg_alert.alert_etl | ||
| type: keyword | ||
| description: Alert ETL | ||
| - name: dg_alert.alert_etu | ||
| type: date | ||
| description: Alert ETU | ||
| - name: dg_alert.alert_ur | ||
| type: date | ||
| description: Alert UR |
Contributor
There was a problem hiding this comment.
Suggested change
| - name: dg_alert.alert_etl | |
| type: keyword | |
| description: Alert ETL | |
| - name: dg_alert.alert_etu | |
| type: date | |
| description: Alert ETU | |
| - name: dg_alert.alert_ur | |
| type: date | |
| description: Alert UR | |
| - name: dg_alert.alert_etl | |
| type: date | |
| description: Alert ETL | |
| - name: dg_alert.alert_etu | |
| type: date | |
| description: Alert ETU | |
| - name: dg_alert.alert_ur | |
| type: keyword | |
| description: Alert UR |
|
💚 Build Succeeded
History
cc @efd6 |
kcreddy
approved these changes
Feb 20, 2025
Contributor
|
Package digital_guardian - 1.4.0 containing this change is available at https://epr.elastic.co/package/digital_guardian/1.4.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Note
Alternative approach is to keep the field type as an integer and map to yes/no to 1/0. This is not ideal.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots